Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement split comms watchdog #18599

Merged
merged 5 commits into from
Oct 6, 2022
Merged

Implement split comms watchdog #18599

merged 5 commits into from
Oct 6, 2022

Conversation

daskygit
Copy link
Member

@daskygit daskygit commented Oct 5, 2022

Description

Only had minimal testing so far, but this will allow for some feedback.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

KarlK90
KarlK90 requested changes Oct 5, 2022
View reviewed changes
Copy link
Member

@KarlK90 KarlK90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great feature 🎉. From my testing this works great and I found only one tiny edge case.

quantum/split_common/split_util.c Show resolved Hide resolved
@daskygit daskygit marked this pull request as ready for review October 5, 2022 21:15
@daskygit
Copy link
Member Author

daskygit commented Oct 5, 2022

Not entirely happy with the DD mapping

KarlK90
KarlK90 approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@KarlK90 KarlK90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now!

@tzarc tzarc merged commit c255174 into qmk:develop Oct 6, 2022
@daskygit daskygit deleted the feature/split_watchdog branch October 6, 2022 10:22
@daskygit daskygit mentioned this pull request Oct 6, 2022
Closed
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@daskygit @ramonimbao
Implement split comms watchdog (qmk#18599)
95f032b
@zhyu zhyu mentioned this pull request Oct 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@tzarc tzarc tzarc approved these changes

@KarlK90 KarlK90 KarlK90 approved these changes

Assignees
No one assigned
Labels
core documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@daskygit @drashna @tzarc @KarlK90