Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Fix ST7565 handler deadlock #18609

Merged
merged 1 commit into from
Oct 5, 2022
Merged

[Bug] Fix ST7565 handler deadlock #18609

merged 1 commit into from
Oct 5, 2022

Conversation

KarlK90
Copy link
Member

@KarlK90 KarlK90 commented Oct 5, 2022

Description

Use manually locking for the ST7565 handler, otherwise we'll deadlock when acquiring the shared memory lock twice.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@KarlK90
Use manually locking for the ST7565 handler
2ae3fe1 
Otherwise we'll deadlock when acquiring the shared memory lock twice.
@KarlK90 KarlK90 requested review from daskygit and a team October 5, 2022 17:16
@github-actions github-actions bot added the core label Oct 5, 2022
@KarlK90 KarlK90 merged commit c76d207 into qmk:develop Oct 5, 2022
@KarlK90 KarlK90 deleted the fix/st7565-handler-deadlock branch October 5, 2022 17:22
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@KarlK90 @ramonimbao
[Bug] Fix ST7565 handler deadlock (qmk#18609)
2d0c4c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@daskygit daskygit daskygit approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KarlK90 @fauxpark @daskygit