Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/Update ChibiOS hardware ID #18613

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Fix/Update ChibiOS hardware ID #18613

merged 1 commit into from
Oct 5, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Oct 5, 2022 •
edited

Description

  • fix missing stm32 bytes
  • bodge RP2040 support

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team October 5, 2022 19:51
@github-actions github-actions bot added the core label Oct 5, 2022
@zvecr zvecr changed the title Update ChibiOS hardware ID Fix/Update ChibiOS hardware ID Oct 5, 2022
KarlK90
KarlK90 approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@KarlK90 KarlK90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zvecr zvecr merged commit f120b39 into qmk:develop Oct 5, 2022
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@zvecr @ramonimbao
Update ChibiOS hardware ID (qmk#18613)
8009f45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@KarlK90 KarlK90 KarlK90 approved these changes

Assignees
No one assigned
Labels
bug core enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zvecr @tzarc @KarlK90