Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow QK_MAKE to work with converters #18637

Merged
merged 3 commits into from
Oct 8, 2022
Merged

Allow QK_MAKE to work with converters #18637

merged 3 commits into from
Oct 8, 2022

Conversation

Jpe230
Copy link
Contributor

@Jpe230 Jpe230 commented Oct 7, 2022

Description

Allow QK_MAKE to write the converter flag if enabled:

Eg: qmk compile -kb crkbd/rev1 -km jpe230 -e CONVERT_TO=kb2040

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Oct 7, 2022
@drashna drashna requested a review from a team October 8, 2022 00:23
zvecr
zvecr reviewed Oct 8, 2022
View reviewed changes
builddefs/converters.mk Outdated Show resolved Hide resolved
@Jpe230 Jpe230 requested review from zvecr and drashna and removed request for zvecr October 8, 2022 02:28
@drashna drashna merged commit 86938fd into qmk:develop Oct 8, 2022
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@Jpe230 @ramonimbao
Allow QK_MAKE to work with converters (qmk#18637)
d5ee41b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Jpe230 @drashna @zvecr