Allow changes to the moonlander default music map #18715
Conversation
keyboards/moonlander/moonlander.c
Outdated
| 24, 25, 26, 27, 28, 29, 29, 30, 30, 31, 32, 33, 34, 35, | ||
| 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, | ||
| 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, | ||
| 5, 5, 5, 6, 6, 6 |
There was a problem hiding this comment.
These really should be different values.
There was a problem hiding this comment.
Why? Try it, it makes a lot of sense. Sure, the hit-area for 53, 54, 41, 42, 29, 30, 5, and 6 is rather large, but these are also the hardest to hit from the resting position on the home row.
There was a problem hiding this comment.
Hardest to hit is absolutely subjective. Eg, on mine, hitting the different thumb keys is very easy for me, as my thumb sits in the center key in the thumb cluster, when my fingers are on the home row. And I'm very used to using my thumb a lot. So setting all of these keys to be the same thing is a literal waste.
And while I definitely understand that not everyone uses the board like me, ... well, that's still my point: that somebody likely will want to have these as different notes/positions.
What might be better/simpler in the long run is adding __attribute__((weak)) to the variable, so that it can be changed in a users keymap.
There was a problem hiding this comment.
Fair enough. I just thought a highly structured layout (basically five rows of 12 tones each) was a better default.
If you edit: I misread the code and will change this PR into one that makes the map weak.undef MUSIC_MAP, wouldn't that allow you to define a music_map of your own in your keymap?
There was a problem hiding this comment.
I've changed the PR so that it no longer picks a different default, but rather allows redefinition by the addition of __attribute__((weak)). Thanks for the suggestion, @drashna!
This allows user keymaps to set a different music map.
joukewitteveen
changed the title
joukewitteveen
force-pushed
the
moonlander-music-map
branch
from
67e584b
to
4613a47
Compare
This allows user keymaps to set a different music map.
Description
A music map where each row has the same length is a lot more intuitive. With a chromatic scale, having rows of twelve tones is especially nice.
Types of Changes
Checklist