Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

led_update_kb -> led_update_ports where appropriate #18716

Merged
merged 1 commit into from
Oct 15, 2022
Merged

led_update_kb -> led_update_ports where appropriate #18716

merged 1 commit into from
Oct 15, 2022

Conversation

joukewitteveen
Copy link
Contributor

Description

Following #14452, less boilerplate is needed to customize indicator led control.

I went through the keyboard .c files and updated those instances where the change was straightforward. I did not touch instances where the implementation consisted solely of writePin invocations, because I believe nearly all of those functions could go and be replaced by the desired LED pin defines.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python - No style changes introduced.
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@joukewitteveen
led_update_kb -> led_update_ports where appropriate
2423a8f 
Following qmk#14452, less boilerplate is needed to customize indicator led
control.
@drashna drashna requested a review from a team October 14, 2022 17:08
@spidey3 spidey3 merged commit 2ee573f into qmk:develop Oct 15, 2022
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@joukewitteveen @ramonimbao
led_update_kb -> led_update_ports where appropriate (qmk#18716)
90d4a0b 
Following qmk#14452, less boilerplate is needed to customize indicator led
control.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spidey3 spidey3 spidey3 approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joukewitteveen @drashna @spidey3