Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update converter/usb_usb user keymaps to use LAYOUT_fullsize #18720

Merged
merged 1 commit into from
Oct 15, 2022

Conversation

precondition
Copy link
Contributor

@precondition precondition commented Oct 14, 2022

Description

Update @chriskopher's and @BalzGuenat 's (aka coloneljesus) converter/usb_usb keymap to the new LAYOUT_fullsize_(ansi|iso) macros (LAYOUT_(ansi|iso) macros were removed in #16773)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • Compilation errors when compiling converter/usb_usb/*:coloneljesus and converter/usb_usb/*:chriskopher

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@precondition precondition changed the title Update converter/usb_usb keymaps to use LAYOUT_fullsize Update converter/usb_usb user keymaps to use LAYOUT_fullsize Oct 14, 2022
@precondition
Copy link
Contributor Author

precondition commented Oct 14, 2022

Creating load file for flashing: .build/converter_usb_usb_ble_chriskopher.hex                       [OK]
Copying converter_usb_usb_ble_chriskopher.hex to qmk_firmware folder                                [OK]
Checking file size of converter_usb_usb_ble_chriskopher.hex
 * The firmware is too large! 30972/28672 (2300 bytes over)
 [ERRORS]

gmake[1]: *** [builddefs/common_rules.mk:390: check-size] Error 1
Make finished with errors
gmake: *** [Makefile:414: converter/usb_usb/ble:chriskopher] Error 1

Welp, solving oversize user firmware build is out-of-scope for this PR ¯\_ (ツ)_/¯

@spidey3 spidey3 requested a review from a team October 15, 2022 16:40
@zvecr zvecr merged commit 2b24f16 into qmk:develop Oct 15, 2022
@precondition precondition deleted the LAYOUT_fullsize_usb_usb branch October 16, 2022 04:19
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants