Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove RGBLIGHT_ANIMATION and clean up effect defines for G-K #18726

Merged
merged 1 commit into from
Oct 15, 2022
Merged

Remove RGBLIGHT_ANIMATION and clean up effect defines for G-K #18726

merged 1 commit into from
Oct 15, 2022

Conversation

drashna
Copy link
Member

@drashna drashna commented Oct 15, 2022

Description

Replace RGBLIGHT_ANIMATIONS with explicitly defined effects, and remove unused config blocks for rgblight effects.

Types of Changes

  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team October 15, 2022 03:23
spidey3
spidey3 approved these changes Oct 15, 2022
View reviewed changes
Copy link
Contributor

@spidey3 spidey3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@drashna drashna merged commit 55b9a4d into qmk:develop Oct 15, 2022
@drashna drashna deleted the rgb_animations_part_2 branch October 15, 2022 16:55
spidey3 added a commit to spidey3/qmk_firmware that referenced this pull request Oct 15, 2022
@spidey3
A little cleanup after qmk#18726
d7aef39
@spidey3 spidey3 mentioned this pull request Oct 15, 2022
Merged
14 tasks
zvecr pushed a commit that referenced this pull request Oct 18, 2022
@spidey3
A little personal cleanup after #18726 and #18729 (#18734)
80fdbfc 
* A little cleanup after #18726

* Re-instate RGBLIGHT_EFFECT_STATIC_GRADIENT

* Extend to spin
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@drashna @ramonimbao
Remove RGBLIGHT_ANIMATION and clean up effect defines for G-K (qmk#18726
b26cda4 
)
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@spidey3 @ramonimbao
A little personal cleanup after qmk#18726 and qmk#18729 (qmk#18734)
45df1c6 
* A little cleanup after qmk#18726

* Re-instate RGBLIGHT_EFFECT_STATIC_GRADIENT

* Extend to spin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@spidey3 spidey3 spidey3 approved these changes

Assignees
No one assigned
Labels
keyboard keymap optimization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@drashna @fauxpark @spidey3