Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A little personal cleanup after #18726 and #18729 #18734

Merged
merged 3 commits into from
Oct 18, 2022
Merged

A little personal cleanup after #18726 and #18729 #18734

merged 3 commits into from
Oct 18, 2022

Conversation

spidey3
Copy link
Contributor

@spidey3 spidey3 commented Oct 15, 2022

Description

Just a little cleanup, now that #18726 and #18729 have been merged.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • none

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr merged commit 80fdbfc into qmk:develop Oct 18, 2022
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@spidey3 @ramonimbao
A little personal cleanup after qmk#18726 and qmk#18729 (qmk#18734)
45df1c6 
* A little cleanup after qmk#18726

* Re-instate RGBLIGHT_EFFECT_STATIC_GRADIENT

* Extend to spin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@spidey3 @zvecr