Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add converter support to keymap.json #18776

Merged
merged 2 commits into from
Oct 21, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Oct 19, 2022

Description

Building on the recent bug fixes, its now possible to add in support for CONVERT_TO. Eventually this could power a drop down somewhere on configurator.

Potentially it could extend the existing config object, and reuse mappings/info_rules.json...?

Key (and potentially any parents) up for grabs still.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added cli qmk cli command python labels Oct 19, 2022
@zvecr zvecr marked this pull request as ready for review October 20, 2022 13:35
@drashna drashna merged commit 345f19a into qmk:develop Oct 21, 2022
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli qmk cli command python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants