wilba_tech: allow keymaps to override backlight_effect_indicators() #18791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
approved these changes
Oct 21, 2022
zvecr
approved these changes
Oct 21, 2022
ramonimbao
pushed a commit
to ramonimbao/qmk_firmware
that referenced
this pull request
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As the title says, this allows user keymaps to override backlight_effect_indicators() for keyboards which use Wilba Tech RGB.
I wanted to light things up in a custom way to show each key defined in each active non-base layer, plus extra lighting for modifier keys. With this one-line change, now I can.
The Wilba Tech code doesn't have a _kb() / _user() abstraction for customizing this, and I don't want to break anyone's keymaps by changing the API, so I just made the function weak.
Types of Changes
Checklist