Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix garbled test output #18822

Merged
merged 2 commits into from
Oct 23, 2022
Merged

Fix garbled test output #18822

merged 2 commits into from
Oct 23, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Oct 23, 2022

Description

Currently some tests output as,

Testing secure
Running 10 tests from 1 test suite.
[==========] [----------] Global test environment set-up.
10 tests from Secure[----------] 
Secure.test_lock[ RUN      ] 
Secure.test_lock (0 ms)
[       OK ] Secure.test_unlock_timeout[ RUN      ] 
Secure.test_unlock_timeout (0 ms)
[       OK ] Secure.test_unlock_request[ RUN      ] 
Secure.test_unlock_request (0 ms)
[       OK ] Secure.test_unlock_request_fail[ RUN      ] 
Secure.test_unlock_request_fail (0 ms)
[       OK ] Secure.test_unlock_request_timeout[ RUN      ] 
Secure.test_unlock_request_timeout (0 ms)
[       OK ] Secure.test_unlock_request_fail_mid[ RUN      ] 
Secure.test_unlock_request_fail_mid (0 ms)
[       OK ] Secure.test_unlock_request_fail_out_of_order[ RUN      ] 
Secure.test_unlock_request_fail_out_of_order (0 ms)
[       OK ] Secure.test_unlock_request_on_layer[ RUN      ] 
Secure.test_unlock_request_on_layer (0 ms)
[       OK ] Secure.test_unlock_request_mid_stroke[ RUN      ] 
Secure.test_unlock_request_mid_stroke (0 ms)
[       OK ] Secure.test_unlock_request_mods[ RUN      ] 
Secure.test_unlock_request_mods (0 ms)
[       OK ] 10 tests from Secure (3 ms total)

[----------] [----------] Global test environment tear-down
10 tests from 1 test suite ran. (3 ms total)[==========] 
10 tests.
[  PASSED  ] 

Issue is due to a mixture of stdout/stderr and gtest flushing stdout.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added the bug label Oct 23, 2022
@zvecr zvecr requested a review from a team October 23, 2022 00:26
@github-actions github-actions bot added the core label Oct 23, 2022
@zvecr zvecr merged commit 64ca14f into qmk:develop Oct 23, 2022
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
* Fix garbled test output

* Correct SRC listing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants