Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate SECURE_* keycodes for QK_SECURE_* #18847

Merged
merged 4 commits into from
Oct 25, 2022
Merged

Deprecate SECURE_* keycodes for QK_SECURE_* #18847

merged 4 commits into from
Oct 25, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Oct 25, 2022 •
edited

Description

Also adds short form aliases.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested review from fauxpark and a team October 25, 2022 17:56
fauxpark
fauxpark reviewed Oct 25, 2022
View reviewed changes
docs/feature_secure.md Outdated Show resolved Hide resolved
@zvecr @fauxpark
Apply suggestions from code review
e48255c 
Co-authored-by: Ryan <fauxpark@gmail.com>
@zvecr zvecr merged commit ec2414c into qmk:develop Oct 25, 2022
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@zvecr @fauxpark @ramonimbao
Deprecate SECURE_* keycodes for QK_SECURE_* (qmk#18847)
0691265 
* Deprecate SECURE_* keycodes for QK_SECURE_*

* Update keycode process

* Update process_secure.c

* Apply suggestions from code review

Co-authored-by: Ryan <fauxpark@gmail.com>

Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
core documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zvecr @fauxpark