Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalise Space Cadet keycodes #18864

Merged
merged 1 commit into from
Oct 27, 2022
Merged

Normalise Space Cadet keycodes #18864

merged 1 commit into from
Oct 27, 2022

Conversation

fauxpark
Copy link
Member

Description

KC_LSPO -> SC_LSPO etc.
KC_SFTENT -> SC_SENT

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark added enhancement core keyboard keymap documentation via Adds via keymap and/or updates keyboard for via support labels Oct 27, 2022
@fauxpark fauxpark requested a review from a team October 27, 2022 02:34
@zvecr zvecr merged commit 002b58f into qmk:develop Oct 27, 2022
@fauxpark fauxpark deleted the deprecate-space-cadet-keycodes branch October 27, 2022 10:35
This was referenced Oct 27, 2022
Merged
Merged
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@fauxpark @ramonimbao
Normalise Space Cadet keycodes (qmk#18864)
7a443f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
core documentation enhancement keyboard keymap python via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fauxpark @zvecr