Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow overriding of dynamic keymap start address. #18867

Merged
merged 1 commit into from
Oct 27, 2022
Merged

Allow overriding of dynamic keymap start address. #18867

merged 1 commit into from
Oct 27, 2022

Conversation

tzarc
Copy link
Member

@tzarc tzarc commented Oct 27, 2022

Description

As per the title.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested a review from a team October 27, 2022 06:44
@github-actions github-actions bot added the core label Oct 27, 2022
KarlK90
KarlK90 approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@KarlK90 KarlK90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tzarc tzarc merged commit 91b1e8a into qmk:develop Oct 27, 2022
@tzarc tzarc deleted the dynamic_keymap_start_override branch October 27, 2022 07:29
@tzarc
Copy link
Member Author

tzarc commented Oct 27, 2022

CI failure unrelated.

ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@tzarc @ramonimbao
Allow overriding of dynamic keymap start address. (qmk#18867)
39b44cf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@KarlK90 KarlK90 KarlK90 approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tzarc @fauxpark @KarlK90