Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Missing a column of LEDs, and LED count was incorrect. Confirmed with video of PCB on Mechlovin Youtube channel.
Removed math expressions and corrected LED count (PCB appears to have 100 keys + 4 logo).
Last row seemed to be missing most of the LEDs. No position info available for underglow LEDs, so they were removed for now.
No position info available for underglow LEDs, so they were removed for now.
No position info available for underglow LEDs, so they were removed for now.
Added flags and positions (at 0,0) for 8 underglow LEDs.
Added missing flags.
Removed macro for calculating positions. Also fixed a missing ).
No design files available; renumbered LED indexes to be contiguous and adjusted LED count.
Removed math expressions.
Removed math expressions.
Removed math expressions.
cc @Xelus22 @ryanskidmore @vuhopkep @ToastyStoemp @mechlovin @melgeek001365 @cmdremily
Types of Changes
Issues Fixed or Closed by This PR
Checklist