Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handwired/swiftrax/walter: fix layout mismatch #18974

Merged
merged 2 commits into from
Nov 6, 2022

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Nov 6, 2022

Description

☒ handwired/swiftrax/walter: Number of keys for LAYOUT_65_ansi does not match! info.json specifies 67 keys, C macro specifies 68
☒ handwired/swiftrax/walter: Number of keys for LAYOUT_65_ansi_splitbs does not match! info.json specifies 68 keys, C macro specifies 69

Removed an extra key behind the ISO enter in the info.json (that happens to silence these errors for the ISO layouts). Adjusted bottom row in info.json to match the "standard" 65% layout.

cc @swiftrax

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team November 6, 2022 14:12
@zvecr zvecr merged commit 5f9b7c0 into qmk:develop Nov 6, 2022
@fauxpark fauxpark deleted the walter-layout-fix branch November 7, 2022 00:31
@fauxpark fauxpark mentioned this pull request Nov 7, 2022
14 tasks
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
* `handwired/swiftrax/walter`: fix layout mismatch

* Undo K4A removal, fix info.json instead
elpekenin pushed a commit to elpekenin/qmk_firmware that referenced this pull request Dec 7, 2022
* `handwired/swiftrax/walter`: fix layout mismatch

* Undo K4A removal, fix info.json instead
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants