Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mechlovin/adelais/standard_led/avr/rev1: fix layout #18997

Merged
merged 1 commit into from
Nov 8, 2022
Merged

mechlovin/adelais/standard_led/avr/rev1: fix layout #18997

merged 1 commit into from
Nov 8, 2022

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Nov 8, 2022

Description

☒ mechlovin/adelais/standard_led/avr/rev1: Number of keys for LAYOUT_alice_full_rshift does not match! info.json specifies 64 keys, C macro specifies 65

Extra key in this layout macro which wasn't mapped anywhere.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team November 8, 2022 02:16
@fauxpark fauxpark merged commit 1514365 into qmk:develop Nov 8, 2022
@fauxpark fauxpark deleted the adelais-layout-fix branch November 8, 2022 03:17
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@fauxpark @ramonimbao
mechlovin/adelais/standard_led/avr/rev1: fix layout (qmk#18997)
2d72e48
elpekenin pushed a commit to elpekenin/qmk_firmware that referenced this pull request Dec 7, 2022
@fauxpark @elpekenin
mechlovin/adelais/standard_led/avr/rev1: fix layout (qmk#18997)
e7d9c71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

Assignees
No one assigned
Labels
bug keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fauxpark @zvecr