Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gboards/gergoplex: fix matrix pins #18999

Merged
merged 1 commit into from
Nov 8, 2022
Merged

gboards/gergoplex: fix matrix pins #18999

merged 1 commit into from
Nov 8, 2022

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Nov 8, 2022

Description

☒ gboards/gergoplex: MATRIX_COLS is inconsistent with the size of MATRIX_COL_PINS: 5 != 4
☒ gboards/gergoplex: MATRIX_ROWS is inconsistent with the size of MATRIX_ROW_PINS: 4 != 10

Compiles, and shouldn't be any functional change, but I don't have hardware to test.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team November 8, 2022 06:15
keyboard-magpie
keyboard-magpie approved these changes Nov 8, 2022
View reviewed changes
Copy link
Contributor

@keyboard-magpie keyboard-magpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my gergoplex

@zvecr zvecr merged commit d116765 into qmk:develop Nov 8, 2022
@fauxpark fauxpark deleted the gergoplex-fix-matrix-pins branch November 8, 2022 15:52
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@fauxpark @ramonimbao
gboards/gergoplex: fix matrix pins (qmk#18999)
50ed533
elpekenin pushed a commit to elpekenin/qmk_firmware that referenced this pull request Dec 7, 2022
@fauxpark @elpekenin
gboards/gergoplex: fix matrix pins (qmk#18999)
e4df321
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@keyboard-magpie keyboard-magpie keyboard-magpie approved these changes

Assignees
No one assigned
Labels
bug keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fauxpark @zvecr @keyboard-magpie