Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onekey: disable NKRO and mousekeys by default #19038

Merged
merged 1 commit into from
Nov 12, 2022

Conversation

fauxpark
Copy link
Member

Description

⚠ handwired/onekey/bluepill_f103c6: Feature mousekey is specified in both info.json and rules.mk, the rules.mk value wins.
⚠ handwired/onekey/bluepill_f103c6: Feature nkro is specified in both info.json and rules.mk, the rules.mk value wins.

These features are hard to properly test with only a single key, and with CI in place checking that it at least compiles is already done.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr merged commit 8cecf7f into qmk:develop Nov 12, 2022
@fauxpark fauxpark deleted the onekey-disable-nkro-mouse branch November 12, 2022 06:01
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
elpekenin pushed a commit to elpekenin/qmk_firmware that referenced this pull request Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants