Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default limit to OLED dirty processing #19068

Merged
merged 3 commits into from
Nov 14, 2022
Merged

Add default limit to OLED dirty processing #19068

merged 3 commits into from
Nov 14, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Nov 13, 2022 •
edited

Description

In response to #18887 (comment).

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Nov 13, 2022
@zvecr zvecr requested review from sigprof and a team November 13, 2022 21:05
sigprof
sigprof approved these changes Nov 13, 2022
View reviewed changes
Copy link
Contributor

@sigprof sigprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable; works on STM32F401 (did not actually test the “always dirty” case though, which is what prompted the original PR).

@sigprof sigprof mentioned this pull request Nov 13, 2022
Merged
14 tasks
@zvecr zvecr merged commit 0719d68 into qmk:develop Nov 14, 2022
@zvecr zvecr deleted the feature/oled_dirty_limit branch November 23, 2022 19:34
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@zvecr @ramonimbao
Add default limit to OLED dirty processing (qmk#19068)
dcef384
elpekenin pushed a commit to elpekenin/qmk_firmware that referenced this pull request Dec 7, 2022
@zvecr @elpekenin
Add default limit to OLED dirty processing (qmk#19068)
ddb9f74
crembz pushed a commit to crembz/qmk_firmware that referenced this pull request Dec 18, 2022
@zvecr @crembz
Add default limit to OLED dirty processing (qmk#19068)
e98df93
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark left review comments

@sigprof sigprof sigprof approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zvecr @sigprof @fauxpark