Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests that caps word stays active after use of OSL #19303

Merged
merged 1 commit into from
Dec 12, 2022
Merged

Tests that caps word stays active after use of OSL #19303

merged 1 commit into from
Dec 12, 2022

Conversation

precondition
Copy link
Contributor

Description

Add tests that tapping or holding a OSL keeps caps word active and shifts keys on the layer that need to be shifted.
These tests address issue #18136.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Dec 12, 2022
@drashna drashna requested a review from a team December 12, 2022 21:12
@KarlK90 KarlK90 merged commit 454edf6 into qmk:develop Dec 12, 2022
@KarlK90
Copy link
Member

KarlK90 commented Dec 12, 2022

LGTM and thanks!

@precondition precondition deleted the caps_word_osl_test branch December 12, 2022 23:32
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
@precondition @omikronik
Tests that caps word stays active after use of OSL (qmk#19303)
700365d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@KarlK90 KarlK90 KarlK90 approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@precondition @KarlK90 @drashna