Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Append user variables to the end of make command #20177

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Append user variables to the end of make command #20177

merged 1 commit into from
Apr 3, 2023

Conversation

filterpaper
Copy link
Contributor

@filterpaper filterpaper commented Mar 18, 2023 •
edited
Loading

Description

Append user environment variables after the ones constructed from configurator json file. This will allow user defined variables (such as TARGET) to be used.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added cli qmk cli command python labels Mar 18, 2023
@filterpaper filterpaper changed the title Append user env after json make command Append user variables at the end Mar 18, 2023
@filterpaper filterpaper changed the title Append user variables at the end Append user variables to the end of make command Mar 19, 2023
@drashna drashna requested a review from a team March 21, 2023 18:35
@tzarc tzarc merged commit 47a51fd into qmk:develop Apr 3, 2023
@filterpaper filterpaper deleted the json-build-change branch April 3, 2023 06:04
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@filterpaper @coquizen
Append user variables to the end of make command (qmk#20177)
b33e2e8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
cli qmk cli command python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@filterpaper @drashna @tzarc