Skip to content

qmk new-keyboard - detach community layout when selecting "none of the above" #20405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2024
Merged

qmk new-keyboard - detach community layout when selecting "none of the above" #20405

merged 1 commit into from
Mar 14, 2024

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Apr 10, 2023 •
edited
Loading

Description

Might help somewhat for those PRs were the submitter has failed to rename the layout after adding/removing keys.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added cli qmk cli command python labels Apr 10, 2023
@github-actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jul 16, 2023
@github-actions
Copy link

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.
// [stale-action-closed]

@github-actions github-actions bot closed this Aug 16, 2023
@zvecr zvecr reopened this Aug 16, 2023
@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Aug 17, 2023
@github-actions
Copy link

github-actions bot commented Oct 1, 2023

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Oct 1, 2023
@zvecr zvecr added awaiting review and removed stale Issues or pull requests that have become inactive without resolution. labels Oct 1, 2023
@tzarc tzarc merged commit 6720e9c into qmk:develop Mar 14, 2024
@zvecr zvecr deleted the detach_layout branch March 14, 2024 10:24
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Apr 4, 2024
@zvecr @mechlovin
qmk new-keyboard - detach community layout when selecting "none of …
ed34f54 
…the above" (qmk#20405)
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Apr 4, 2024
@zvecr @mechlovin
qmk new-keyboard - detach community layout when selecting "none of …
b7eaf6d 
…the above" (qmk#20405)
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Apr 15, 2024
@zvecr @mechlovin
qmk new-keyboard - detach community layout when selecting "none of …
518f97a 
…the above" (qmk#20405)
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@zvecr @whoisjordangarcia
qmk new-keyboard - detach community layout when selecting "none of …
04e1405 
…the above" (qmk#20405)
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@zvecr @nuess0r
qmk new-keyboard - detach community layout when selecting "none of …
45104ab 
…the above" (qmk#20405)
Ardakilic pushed a commit to Ardakilic/qmk_firmware that referenced this pull request Sep 10, 2024
@zvecr @Ardakilic
qmk new-keyboard - detach community layout when selecting "none of …
b85eea7 
…the above" (qmk#20405)
MasayukiFukada pushed a commit to MasayukiFukada/qmk_firmware that referenced this pull request May 1, 2025
@zvecr @MasayukiFukada
qmk new-keyboard - detach community layout when selecting "none of …
6fa31d6 
…the above" (qmk#20405)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
awaiting review cli qmk cli command enhancement python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zvecr @tzarc