Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Acheron Austin Layout Macro Conversion and Additions #20443

Merged
merged 11 commits into from
Apr 17, 2023
Merged

Acheron Austin Layout Macro Conversion and Additions #20443

merged 11 commits into from
Apr 17, 2023

Conversation

noroadsleft
Copy link
Member

Description

  • converts LAYOUT_all to data-driven
  • adds eight new layout macros with reference keymaps

cc @Gondolindrim (keyboard maintainer)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft noroadsleft requested a review from a team April 13, 2023 19:42
@drashna drashna requested a review from a team April 15, 2023 09:46
@noroadsleft noroadsleft changed the base branch from master to develop April 17, 2023 00:01
@github-actions github-actions bot added CI core documentation translation via Adds via keymap and/or updates keyboard for via support labels Apr 17, 2023
@noroadsleft noroadsleft removed core documentation translation CI via Adds via keymap and/or updates keyboard for via support labels Apr 17, 2023
@noroadsleft noroadsleft merged commit ce4205b into qmk:develop Apr 17, 2023
@noroadsleft noroadsleft deleted the kb_layouts/acheron_austin branch April 17, 2023 01:08
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@noroadsleft @coquizen
Acheron Austin Layout Macro Conversion and Additions (qmk#20443)
c461780 
* add matrix_diagram.md

* info.json: apply friendly formatting

* add LAYOUT_ansi_split_bs

* add LAYOUT_ansi

* add LAYOUT_ansi_wkl_split_bs

* add LAYOUT_ansi_wkl

* add LAYOUT_iso_split_bs

* add LAYOUT_iso

* add LAYOUT_iso_wkl_split_bs

* add LAYOUT_iso_wkl

* add reference keymaps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
enhancement keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@noroadsleft @drashna