Skip to content

Alf X2 Layout Macro Additions #20495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 23, 2023
Merged

Alf X2 Layout Macro Additions #20495

merged 5 commits into from
Apr 23, 2023

Conversation

noroadsleft
Copy link
Member

Description

  • adds two layout macros
  • refactors hhkb_60 keymap to use the new LAYOUT_ansi_split_bs_rshift macro
  • adds layout/matrix diagram

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft noroadsleft requested a review from a team April 18, 2023 18:52
@noroadsleft noroadsleft changed the title Alf X2 Alf X2 Layout Macro Additions Apr 18, 2023
@drashna drashna requested a review from a team April 22, 2023 08:19
@noroadsleft noroadsleft merged commit 32e2875 into qmk:develop Apr 23, 2023
@noroadsleft noroadsleft deleted the kb_layouts/alf_x2 branch April 23, 2023 00:24
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@noroadsleft @coquizen
Alf X2 Layout Macro Additions (qmk#20495)
00aec65 
* add matrix_diagram.md

* info.json: apply friendly formatting

* add LAYOUT_ansi_split_bs_rshift

* add LAYOUT_ansi

* refactor hhkb_60 keymap

Refactor the `hhkb_60` keymap to use the `LAYOUT_ansi_split_bs_rshift` macro.
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@noroadsleft @autoferrit
Alf X2 Layout Macro Additions (qmk#20495)
8bec158 
* add matrix_diagram.md

* info.json: apply friendly formatting

* add LAYOUT_ansi_split_bs_rshift

* add LAYOUT_ansi

* refactor hhkb_60 keymap

Refactor the `hhkb_60` keymap to use the `LAYOUT_ansi_split_bs_rshift` macro.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
enhancement keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noroadsleft @drashna