Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Fix nk plus ws2812 config #20524

Merged
merged 1 commit into from
Apr 21, 2023
Merged

[Keyboard] Fix nk plus ws2812 config #20524

merged 1 commit into from
Apr 21, 2023

Conversation

drashna
Copy link
Member

@drashna drashna commented Apr 21, 2023

Description

rgblight -> ws2812 for pin config

Types of Changes

  • Bugfix
  • Keyboard (addition or update)

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team April 21, 2023 19:49
keyboard-magpie
keyboard-magpie approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@keyboard-magpie keyboard-magpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I keep forgetting this recent change, sorry.

@daskygit daskygit merged commit ff6855c into qmk:develop Apr 21, 2023
@drashna drashna deleted the fix/nk_plus branch April 21, 2023 20:04
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@drashna @coquizen
[Keyboard] Fix nk plus ws2812 config (qmk#20524)
47bea01
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@drashna @autoferrit
[Keyboard] Fix nk plus ws2812 config (qmk#20524)
aed8df0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keyboard-magpie keyboard-magpie keyboard-magpie approved these changes

@daskygit daskygit daskygit approved these changes

Assignees
No one assigned
Labels
bug keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@drashna @keyboard-magpie @daskygit