Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FJLabs Sinanju WK Layout Additions and Touch-Up #20628

Merged
merged 12 commits into from
Apr 30, 2023
Merged

FJLabs Sinanju WK Layout Additions and Touch-Up #20628

merged 12 commits into from
Apr 30, 2023

Conversation

noroadsleft
Copy link
Member

Description

  • rename LAYOUT_all to LAYOUT_60_ansi_split_bs_rshift
  • add five new layouts
  • enable Community Layout support
  • fix Configurator implementation (off-by-one sequence error)
  • add layout/matrix diagram
  • edit listed maintainer (reference GitHub username)

cc @mrnoisytiger (keyboard maintainer)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Apr 29, 2023
@noroadsleft noroadsleft requested a review from a team April 29, 2023 19:27
@noroadsleft noroadsleft merged commit 2f17ef3 into qmk:develop Apr 30, 2023
@noroadsleft noroadsleft deleted the kb_layouts/fjlabs_sinanjuwk branch April 30, 2023 06:23
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
@noroadsleft @coquizen
FJLabs Sinanju WK Layout Additions and Touch-Up (qmk#20628)
0ce1952 
* add matrix_diagram.md

* refactor keymaps

* fix Configurator implementation

The original C-based code had an off-by-one error in the key sequence, that was then converted in data-driven configurator without being corrected.

* info.json: apply friendly formatting

* rename LAYOUT_all to LAYOUT_60_ansi_split_bs_rshift

* add LAYOUT_60_ansi

* add LAYOUT_60_tsangan_hhkb

* add LAYOUT_60_ansi_tsangan

* add LAYOUT_60_ansi_wkl_split_bs_rshift

* add LAYOUT_60_ansi_wkl

* enable Community Layout support

* edit listed maintainer (reference GitHub username)
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@noroadsleft @autoferrit
FJLabs Sinanju WK Layout Additions and Touch-Up (qmk#20628)
50a9fa3 
* add matrix_diagram.md

* refactor keymaps

* fix Configurator implementation

The original C-based code had an off-by-one error in the key sequence, that was then converted in data-driven configurator without being corrected.

* info.json: apply friendly formatting

* rename LAYOUT_all to LAYOUT_60_ansi_split_bs_rshift

* add LAYOUT_60_ansi

* add LAYOUT_60_tsangan_hhkb

* add LAYOUT_60_ansi_tsangan

* add LAYOUT_60_ansi_wkl_split_bs_rshift

* add LAYOUT_60_ansi_wkl

* enable Community Layout support

* edit listed maintainer (reference GitHub username)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@noroadsleft @fauxpark