Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize, correct, and uniform dactyl_manuform variant 5x6_68 #21299

Merged
merged 3 commits into from
Jul 7, 2023
Merged

Modernize, correct, and uniform dactyl_manuform variant 5x6_68 #21299

merged 3 commits into from
Jul 7, 2023

Conversation

dunk2k
Copy link
Contributor

@dunk2k dunk2k commented Jun 19, 2023

Description

5x6_68 layout macro was not uniform with other extended bottom row variants - this has been amended along with moving definitions form rules.mk to info.json, and an updated readme.md.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • n/a

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@dunk2k dunk2k changed the title Modernize, correct, and uniform 'dactyl_manuform variant 5x6_68` Modernize, correct, and uniform dactyl_manuform variant 5x6_68 Jun 19, 2023
@dunk2k
Update keymap.c
d618fe9 
Space! [Portal 2}
@drashna drashna requested a review from a team July 3, 2023 10:39
@tzarc tzarc merged commit 2404559 into qmk:develop Jul 7, 2023
3 checks passed
@dunk2k dunk2k deleted the dm5x6_68_clean branch July 7, 2023 17:05
jesperhellberg pushed a commit to jesperhellberg/qmk_firmware that referenced this pull request Sep 9, 2023
@dunk2k @jesperhellberg
Modernize, correct, and uniform dactyl_manuform variant 5x6_68 (q…
65b9c1c 
…mk#21299)
thismarvin pushed a commit to thismarvin/qmk_firmware that referenced this pull request Sep 27, 2023
@dunk2k @thismarvin
Modernize, correct, and uniform dactyl_manuform variant 5x6_68 (q…
9e71c61 
…mk#21299)
akeep pushed a commit to akeep/qmk_firmware that referenced this pull request Oct 2, 2023
@dunk2k @akeep
Modernize, correct, and uniform dactyl_manuform variant 5x6_68 (q…
fa4819e 
…mk#21299)
csolje pushed a commit to csolje/qmk_firmware that referenced this pull request Oct 21, 2023
@dunk2k @csolje
Modernize, correct, and uniform dactyl_manuform variant 5x6_68 (q…
d886b38 
…mk#21299)
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@dunk2k @autoferrit
Modernize, correct, and uniform dactyl_manuform variant 5x6_68 (q…
5a54e73 
…mk#21299)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@tzarc tzarc tzarc approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dunk2k @drashna @tzarc @fauxpark