Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing fullsize extended default layouts #21402

Merged
merged 5 commits into from
Sep 18, 2023
Merged

Add missing fullsize extended default layouts #21402

merged 5 commits into from
Sep 18, 2023

Conversation

dexter93
Copy link
Contributor

@dexter93 dexter93 commented Jun 28, 2023 •
edited
Loading

Extra 4 keys above the numpad for a total of
108 keys ( ansi)
109 keys ( iso)
113 keys (jis)

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

zvecr
zvecr requested changes Jun 28, 2023
View reviewed changes
Copy link
Member

@zvecr zvecr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

layouts/default/readme.md needs updating with layout diagrams.

@zvecr zvecr requested a review from noroadsleft June 28, 2023 13:48
@dexter93 dexter93 requested a review from zvecr June 28, 2023 13:53
@dunk2k
Copy link
Contributor

dunk2k commented Jun 28, 2023 •
edited
Loading

keyboards these layouts apply:

  • fullsize_extended_ansi:
    • akko/5108
    • handwired/hnah108
    • keychron/q6/ansi
    • keychron/v6/ansi
    • monsgeek/m5
    • xelus/rs108
  • fullsize_extended_iso:
    • handwired/hnah108
    • keychron/q6/iso
    • keychron/v6/iso

@fauxpark fauxpark requested a review from a team September 5, 2023 07:06
@fauxpark fauxpark merged commit 7654549 into qmk:develop Sep 18, 2023
2 checks passed
@dunk2k dunk2k mentioned this pull request Oct 2, 2023
Open
14 tasks
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Oct 25, 2023
@dexter93 @mechlovin
Add missing fullsize extended default layouts (qmk#21402)
622afaf
christrotter pushed a commit to christrotter/qmk_firmware that referenced this pull request Nov 28, 2023
@dexter93 @christrotter
Add missing fullsize extended default layouts (qmk#21402)
2dab1b0
zgagnon pushed a commit to zgagnon/qmk_firmware_waterfowl that referenced this pull request Dec 15, 2023
@dexter93 @zgagnon
Add missing fullsize extended default layouts (qmk#21402)
bb30985
future-figs pushed a commit to future-figs/qmk_firmware that referenced this pull request Dec 27, 2023
@dexter93
Add missing fullsize extended default layouts (qmk#21402)
861de11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@Xelus22 Xelus22 Xelus22 approved these changes

@noroadsleft noroadsleft Awaiting requested review from noroadsleft

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dexter93 @dunk2k @fauxpark @zvecr @Xelus22