Skip to content

Move SPLIT_KEYBOARD to data driven #21410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 39 commits into from
Apr 12, 2024

Conversation

dunk2k
Copy link
Contributor

@dunk2k dunk2k commented Jun 29, 2023

Description

In light of @fauxpark's ongoing efforts to iteratively modernize the entire keyboards directory to data driven format. Rather than it be a one man effort, I'd chip in by moving SPLIT_KEYBOARD from rules.mk to info.json.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the via Adds via keymap and/or updates keyboard for via support label Jun 30, 2023
@dunk2k dunk2k marked this pull request as ready for review June 30, 2023 08:11
@drashna drashna requested a review from a team August 24, 2023 00:38
@fauxpark fauxpark self-assigned this Aug 24, 2023
@dunk2k dunk2k force-pushed the split-keyboard-data-driven branch from ecc6479 to cc9be31 Compare September 22, 2023 15:23
@noroadsleft noroadsleft merged commit 8caa867 into qmk:develop Apr 12, 2024
@noroadsleft
Copy link
Member

Thanks!

whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
Ardakilic pushed a commit to Ardakilic/qmk_firmware that referenced this pull request Sep 10, 2024
MasayukiFukada pushed a commit to MasayukiFukada/qmk_firmware that referenced this pull request May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants