Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added skyloong/Qk21 v1 Number Pad #21467

Merged
merged 9 commits into from
Sep 25, 2023
Merged

Added skyloong/Qk21 v1 Number Pad #21467

merged 9 commits into from
Sep 25, 2023

Conversation

JZ-Skyloong
Copy link
Contributor

Create a number pad keyboard of skyloong.

Description

It's a 21 keys Number Pad with RGB matrix effect. keylayout is 6x4. RGB matrix LED is ws2812.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jul 7, 2023
dunk2k
dunk2k suggested changes Jul 7, 2023
View reviewed changes
keyboards/skyloong/qk21/v1/info.json Outdated Show resolved Hide resolved
@dunk2k
Copy link
Contributor

dunk2k commented Jul 7, 2023

I'm note seeing NUM_LOCK_INDEX anywhere in source code. Is the intention, of NUM_LOCK_INDEX, to enable and change colour of an LED indicator for NUM_LOCK?

@JZ-Skyloong
Copy link
Contributor Author

I'm note seeing NUM_LOCK_INDEX anywhere in source code. Is the intention, of NUM_LOCK_INDEX, to enable and change colour of an LED indicator for NUM_LOCK?

Yes ,it is.

@drashna drashna self-requested a review July 11, 2023 07:39
@drashna drashna requested a review from a team July 11, 2023 07:41
@JZ-Skyloong
Copy link
Contributor Author

What can I do for this PR else? Would you please merge it now? @dunk2k

fauxpark
fauxpark requested changes Aug 5, 2023
View reviewed changes
keyboards/skyloong/qk21/v1/readme.md Outdated Show resolved Hide resolved
JZ-Skyloong and others added 5 commits September 1, 2023 13:09
@JZ-Skyloong
Creat QK21 V1 Keyboard
cd72bf3
@JZ-Skyloong
add image of qk21.
2f6d74c
@JZ-Skyloong @dunk2k
Update keyboards/skyloong/qk21/v1/info.json
c14dffa 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@JZ-Skyloong
update v1.c to save power when USB suspend.
7edf5ac
@JZ-Skyloong @fauxpark
Update keyboards/skyloong/qk21/v1/readme.md
8ddd8b8 
Ok, Thank you for your suggestion.

Co-authored-by: Ryan <fauxpark@gmail.com>
fauxpark
fauxpark requested changes Sep 1, 2023
View reviewed changes
keyboards/skyloong/qk21/v1/info.json Outdated Show resolved Hide resolved
@JZ-Skyloong @fauxpark
Update keyboards/skyloong/qk21/v1/info.json
855f552 
OK.

Co-authored-by: Ryan <fauxpark@gmail.com>
fauxpark
fauxpark requested changes Sep 4, 2023
View reviewed changes
keyboards/skyloong/qk21/v1/config.h Outdated Show resolved Hide resolved
drashna
drashna requested changes Sep 15, 2023
View reviewed changes
keyboards/skyloong/qk21/v1/v1.c Outdated Show resolved Hide resolved
@JZ-Skyloong @drashna
Update keyboards/skyloong/qk21/v1/v1.c
0196826 
OK,Thanks.

Co-authored-by: Drashna Jaelre <drashna@live.com>
@drashna drashna merged commit 234e099 into qmk:develop Sep 25, 2023
3 checks passed
@JZ-Skyloong JZ-Skyloong deleted the qk21_v1 branch September 26, 2023 01:52
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Oct 25, 2023
@JZ-Skyloong @dunk2k
@fauxpark @drashna @mechlovin
Added skyloong/Qk21 v1 Number Pad (qmk#21467)
1df2a4a 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
christrotter pushed a commit to christrotter/qmk_firmware that referenced this pull request Nov 28, 2023
@JZ-Skyloong @dunk2k
@fauxpark @drashna @christrotter
Added skyloong/Qk21 v1 Number Pad (qmk#21467)
56f18c4 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
@JZ-Skyloong JZ-Skyloong mentioned this pull request Dec 2, 2023
Merged
7 tasks
zgagnon pushed a commit to zgagnon/qmk_firmware_waterfowl that referenced this pull request Dec 15, 2023
@JZ-Skyloong @dunk2k
@fauxpark @drashna @zgagnon
Added skyloong/Qk21 v1 Number Pad (qmk#21467)
8aa035c 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
future-figs pushed a commit to future-figs/qmk_firmware that referenced this pull request Dec 27, 2023
@JZ-Skyloong @dunk2k
@fauxpark @drashna
Added skyloong/Qk21 v1 Number Pad (qmk#21467)
144783c 
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunk2k dunk2k dunk2k requested changes

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JZ-Skyloong @dunk2k @drashna @fauxpark