-
-
Notifications
You must be signed in to change notification settings - Fork 42.4k
[Core] Bump mouse endpoint packet size to 16 bytes #21711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Bump mouse endpoint packet size to 16 bytes #21711
Conversation
7f0c1ca to
509f643
Compare
|
Technically this report size check should not be needed, because HID reports are allowed to be larger than the endpoint packet size, and apparently the USB LLD should be able to split large transfers into multiple packets (one complication is when the report size happens to be an integer multiple of the packet size, but smaller than the maximum report size declared in the report descriptor — in that case the device would need to send a zero length packet after the report, and this would need to be done separately from sending the body of report). |
...to accommodate mouse reports with a size of 9 bytes, which happens when the extended 16 bit movement range is activated by defining `MOUSE_EXTENDED_REPORT` and `MOUSE_SHARED_EP` is NOT set.
509f643 to
08da6ac
Compare
report_keyboard_t
|
@sigprof Thanks for the explanation, I wasn't aware of that. I've reverted all of the changes except the mouse endpoint packet size bump, as there is IMHO some value in not having to send out two packets for the extended mouse reports. |
08da6ac to
cc8926a
Compare
report_keyboard_t
Description
...to accommodate mouse reports with a size of 9 bytes, which happens
when the extended 16 bit movement range is activated by defining
MOUSE_EXTENDED_REPORTandMOUSE_SHARED_EPis NOT set.Types of Changes
Issues Fixed or Closed by This PR
mouse_report_thasMOUSE_EXTENDED_REPORTsetChecklist