Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix unxmaal for 60_iso #21975

Merged
merged 3 commits into from
Sep 19, 2023
Merged

fix unxmaal for 60_iso #21975

merged 3 commits into from
Sep 19, 2023

Conversation

dunk2k
Copy link
Contributor

@dunk2k dunk2k commented Sep 11, 2023 •
edited
Loading

Description

fix to prevent unxmaal failing build for, community layout,60_iso.

  • RGBLIGHT settings only apply to keyboard gh60/revc

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • n/a

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@dunk2k dunk2k marked this pull request as ready for review September 11, 2023 20:35
@fauxpark fauxpark requested a review from a team September 12, 2023 01:18
@drashna drashna merged commit 74360d0 into qmk:develop Sep 19, 2023
3 checks passed
@dunk2k dunk2k deleted the comm_unxmaal branch September 19, 2023 07:46
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Oct 25, 2023
@dunk2k @mechlovin
[Keymap] fix unxmaal for 60_iso (qmk#21975)
9e1f1ed
christrotter pushed a commit to christrotter/qmk_firmware that referenced this pull request Nov 28, 2023
@dunk2k @christrotter
[Keymap] fix unxmaal for 60_iso (qmk#21975)
50bf08f
zgagnon pushed a commit to zgagnon/qmk_firmware_waterfowl that referenced this pull request Dec 15, 2023
@dunk2k @zgagnon
[Keymap] fix unxmaal for 60_iso (qmk#21975)
6cf7e62
future-figs pushed a commit to future-figs/qmk_firmware that referenced this pull request Dec 27, 2023
@dunk2k
[Keymap] fix unxmaal for 60_iso (qmk#21975)
c3b8301
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dunk2k @drashna @fauxpark