Fix lower cpi bound on PMW33XX #22108
Merged
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move subtraction after CONSTRAIN to prevent unsigned int wrap These sensors expect a value between `0` and `CPI_MAX/CPI_STEP - 1` Subtracting 1 from `cpi/CPI_STEP` within the `CONSTRAIN` macro causes a wrap to the maximum when attempting to set `cpi` less than `CPI_STEP`. Setting the bounds for `CONSTRAIN` to be between `1` and `CPI_MAX/CPI_STEP` allows impossibly small `cpi` values to be set to the minumum CPI of the sensor, instead of the maximum.
|
@drashna Seems like just the PMW33XX sensors are affected by this. Didn't notice similar handling in the other sensors. |
drashna
approved these changes
Sep 23, 2023
fauxpark
approved these changes
Sep 23, 2023
mechlovin
pushed a commit
to mechlovin/qmk_firmware
that referenced
this pull request
Oct 25, 2023
christrotter
pushed a commit
to christrotter/qmk_firmware
that referenced
this pull request
Nov 28, 2023
zgagnon
pushed a commit
to zgagnon/qmk_firmware_waterfowl
that referenced
this pull request
Dec 15, 2023
future-figs
pushed a commit
to future-figs/qmk_firmware
that referenced
this pull request
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move subtraction after
CONSTRAINto prevent unsigned int wrap on PMW3320, PMW3360, PMW3389Description
These sensors expect a value between
0andCPI_MAX/CPI_STEP - 1Subtracting 1 fromcpi/CPI_STEPwithin theCONSTRAINmacro causes a wrap to the maximum when attempting to setcpiless thanCPI_STEP.Setting the bounds for
CONSTRAINto be between1andCPI_MAX/CPI_STEPallows impossibly smallcpivalues to be set to the minumum CPI of the sensor, instead of the maximum.Tested on Ploopy Classic Trackball (PMW3360)
Types of Changes
Issues Fixed or Closed by This PR
Checklist