Skip to content

Karn: correct layout data #22201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2023
Merged

Karn: correct layout data #22201

merged 1 commit into from
Dec 12, 2023

Conversation

dunk2k
Copy link
Contributor

@dunk2k dunk2k commented Oct 4, 2023 •
edited
Loading

Layout data for Karn is incorrect; change a split_3x6_3 with non-existent positions, set to KC_NO, to custom LAYOUT.

Description

Before:
before

After:
after

  • Layout name renamed to LAYOUT
  • key widths, x y positions, and heights adjusted to match physical PCB
  • Keymaps have been adjusted to match LAYOUT

cc: @robcmills

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • n/a

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr changed the base branch from master to develop October 4, 2023 14:56
@drashna drashna requested a review from a team December 12, 2023 09:25
@waffle87 waffle87 merged commit 02c5afc into qmk:develop Dec 12, 2023
@dunk2k dunk2k deleted the karn_fix branch December 12, 2023 18:38
itsjonny96 pushed a commit to itsjonny96/qmk_firmware that referenced this pull request Jan 7, 2024
@dunk2k @itsjonny96
Karn: correct layout data (qmk#22201)
e01b3be
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 17, 2024
@dunk2k @mechlovin
Karn: correct layout data (qmk#22201)
7bb5865
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 19, 2024
@dunk2k @mechlovin
Karn: correct layout data (qmk#22201)
b3e63b1
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@dunk2k @nuess0r
Karn: correct layout data (qmk#22201)
bcd8515
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

@waffle87 waffle87 waffle87 approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dunk2k @drashna @fauxpark @waffle87