Skip to content

Add solid_reactive effects for MIIIW BlackIO83 #22251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 30, 2024
Merged

Add solid_reactive effects for MIIIW BlackIO83 #22251

merged 2 commits into from
Mar 30, 2024

Conversation

ArthurCyy
Copy link
Contributor

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@ArthurCyy ArthurCyy changed the title Move rgb matrix effects to info.json and fix incorrect position of backlight Move rgb matrix effects to info.json and fix incorrect position of backlight for Blackio83 Oct 11, 2023
@zvecr
Copy link
Member

zvecr commented Oct 11, 2023

keyboard updates and refactors (eg. to data driven) must go through develop

The RGB changes would fall into this category.

For the matrix changes, why are such drastic changes being submitted now? This would highlight that there was no testing done on the original PR.

@ArthurCyy
Copy link
Contributor Author

keyboard updates and refactors (eg. to data driven) must go through develop

The RGB changes would fall into this category.

For the matrix changes, why are such drastic changes being submitted now? This would highlight that there was no testing done on the original PR.

Sorry, I didn't add effects such as solid_reactive before causing me not to notice the problem, which is only visible after applying the solid_reactive effect.

@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Nov 27, 2023
@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Dec 6, 2023
@drashna drashna requested a review from a team December 12, 2023 09:12
@ArthurCyy ArthurCyy requested a review from dunk2k January 7, 2024 07:12
@ArthurCyy ArthurCyy changed the title Move rgb matrix effects to info.json and fix incorrect position of backlight for Blackio83 Move rgb matrix effects to info.json and add solid_reactive effects Jan 8, 2024
@ArthurCyy ArthurCyy changed the title Move rgb matrix effects to info.json and add solid_reactive effects Move rgb matrix effects to info.json and add solid_reactive effects for MIIIW BlackIO83 Jan 8, 2024
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Feb 23, 2024
@dunk2k
Copy link
Contributor

dunk2k commented Mar 21, 2024

branch has conflicts 🙈

dunk2k
dunk2k suggested changes Mar 21, 2024
View reviewed changes
keyboards/miiiw/blackio83/config.h Outdated
# define ENABLE_RGB_MATRIX_PIXEL_RAIN
# define ENABLE_RGB_MATRIX_PIXEL_FLOW
# define ENABLE_RGB_MATRIX_PIXEL_FRACTAL
#define RGB_MATRIX_DEFAULT_MODE RGB_MATRIX_SOLID_COLOR
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is removal of RGB_MATRIX_DEFAULT_MODE intended?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has moved to info.json.

@ArthurCyy ArthurCyy closed this Mar 21, 2024
@ArthurCyy ArthurCyy reopened this Mar 21, 2024
@ArthurCyy
Copy link
Contributor Author

ArthurCyy commented Mar 21, 2024 •
edited
Loading

branch has conflicts 🙈

Solved. @dunk2k

@ArthurCyy ArthurCyy requested a review from dunk2k March 21, 2024 11:24
@ArthurCyy ArthurCyy changed the title Move rgb matrix effects to info.json and add solid_reactive effects for MIIIW BlackIO83 Add solid_reactive effects for MIIIW BlackIO83 Mar 21, 2024
@zvecr zvecr changed the base branch from master to develop March 21, 2024 11:58
@zvecr
Copy link
Member

zvecr commented Mar 21, 2024 •
edited
Loading

keyboard updates and refactors (eg. to data driven) must go through develop

Per the PR checklist, I have updated the base branch to point to develop.

@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Mar 22, 2024
@waffle87 waffle87 merged commit 83625da into qmk:develop Mar 30, 2024
@ArthurCyy ArthurCyy deleted the blackio83 branch April 1, 2024 06:08
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
@ArthurCyy @whoisjordangarcia
Add solid_reactive effects for MIIIW BlackIO83 (qmk#22251)
acabb2a
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@ArthurCyy @nuess0r
Add solid_reactive effects for MIIIW BlackIO83 (qmk#22251)
2ea6880
Ardakilic pushed a commit to Ardakilic/qmk_firmware that referenced this pull request Sep 10, 2024
@ArthurCyy @Ardakilic
Add solid_reactive effects for MIIIW BlackIO83 (qmk#22251)
eaa83f3
MasayukiFukada pushed a commit to MasayukiFukada/qmk_firmware that referenced this pull request May 1, 2025
@ArthurCyy @MasayukiFukada
Add solid_reactive effects for MIIIW BlackIO83 (qmk#22251)
a226e30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@waffle87 waffle87 waffle87 approved these changes

+1 more reviewer

@dunk2k dunk2k dunk2k approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ArthurCyy @zvecr @dunk2k @drashna @waffle87