Skip to content

Add QP support for smaller OLED displays and SSD1306 #22358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 6, 2023

Conversation

infinityis
Copy link
Contributor

Description

Currently QP supports SH1106 displays that are sized 128x64. This PR adds support for OLED displays with a height smaller than 64 pixels. It also updates the documentation to formally include support for SSD1306 displays by way of using the SH1106 driver.

There are additional displays we could add to the list of supported devices, like the 96x16 SSD1306 or the 128x32 SH1106; I do not have these available to test and I am not sure how comprehensive the list needs to be.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@tzarc tzarc requested review from tzarc and a team October 29, 2023 10:14
@tzarc tzarc requested a review from a team October 29, 2023 10:15
@drashna drashna requested a review from a team December 6, 2023 07:37
@zvecr zvecr merged commit 18630b7 into qmk:develop Dec 6, 2023
itsjonny96 pushed a commit to itsjonny96/qmk_firmware that referenced this pull request Jan 7, 2024
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 17, 2024
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 19, 2024
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants