Remove use of broken split.main #22363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fauxpark
approved these changes
Oct 29, 2023
14 tasks
christrotter
pushed a commit
to christrotter/qmk_firmware
that referenced
this pull request
Nov 28, 2023
perezect
added a commit
to perezect/qmk_firmware
that referenced
this pull request
Dec 1, 2023
* Fix old usage of UNICODE_MODE_MAC (qmk#22238) * Resolve invalid keyboard alias targets (qmk#22239) * [Keyboard] Add MIIIW BlackIO83 (qmk#21970) * Add MIIIW BlackIO83 * Improve the code * Updated instructions for entering the bootloader * Update keyboards/miiiw/blackio83/rev_0100/config.h * Update keyboards/miiiw/blackio83/rev_0100/config.h * Update keyboards/miiiw/blackio83/config.h * Update config.h * [Keyboard] MonsGeek M3 (qmk#20542) * Add keybord monsgeek m3. * Add keybord monsgeek m3. * Add keybord monsgeek m3. * updata rules.mk * add readme.md * delete monsgeek\m3\rgb_matrix_kb.inc * add DISABLE_M3_KEYCODES * user_config --> kb_config * Move code to info.json,and removed redundant features * Update keyboards/monsgeek/m3/info.json * Update keyboards/monsgeek/m3/info.json * Update readme.md * Update keyboards/monsgeek/m3/config.h * Update keyboards/monsgeek/m3/info.json * Update keyboards/monsgeek/m3/info.json * Update keyboards/monsgeek/m3/keymaps/default/keymap.c * Update keyboards/monsgeek/m3/keymaps/via/keymap.c * Update keyboards/monsgeek/m3/readme.md * Update m3.c * Update m3.c * Update info.json * Update keymap.c * Update keymap.c * Update config.h * Update keyboards/monsgeek/m3/readme.md * Update keyboards/monsgeek/m3/rules.mk * Update keyboards/monsgeek/m3/info.json * Update keyboards/monsgeek/m3/keymaps/default/keymap.c * Update keyboards/monsgeek/m3/keymaps/via/keymap.c * Update keyboards/monsgeek/m3/info.json * Update keyboards/monsgeek/m3/info.json * Update keyboards/monsgeek/m3/info.json * Update m3.c * Update keyboards/monsgeek/m3/info.json * Update keyboards/monsgeek/m3/m3.c * Update keymap.c replace the tabs with spaces * Update keymap.c replace the tabs with spaces * add missing gpio include for pointing motion pin (qmk#22246) * [Keyboard] Hineybush H101 (qmk#22186) * initial h101 commit * update keymap and add via support * update doc stuff * readme typo * updates * add indicator LEDs, needs testing * update readme * update USB VID/PID to match VIA json * Update keyboards/hineybush/h101/readme.md * Update keyboards/hineybush/h101/keymaps/default/keymap.c * Update keyboards/hineybush/h101/readme.md * Update keyboards/hineybush/h101/keymaps/via/keymap.c * updates from PR comments * updates per PR comments * idk why the folder is acting weird * maybe this will fix it * update to hopefully fix everything weird * keycode fixes * keymap updates * Leeloo v2.1 revision 3 updates (qmk#22236) * add 60_(ansi|iso)_wkl* community layouts (qmk#21811) * add 60_(ansi|iso)_tsangan_wkl* layouts * Update keymap.c * `tsangan_wkl` to `wkl` * update info.json * split backspace changes * Apply suggestions from code review * Keyboard change blu/vimclutch to hardware revision B. (qmk#22247) Co-authored-by: Ryan <fauxpark@gmail.com> * Add Ratio60 PCB (qmk#21609) Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: 4pplet <4pplet@protonmail.com> Co-authored-by: 4pplet <stefan.ess@gmail.com> * Updates to mlego m65 (qmk#20220) Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Ryan <fauxpark@gmail.com> * Add 62 key Dactyl Manuform (qmk#21394) Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Add `60_iso_tsangan_split_bs_rshift` Community Layout (qmk#21812) * add 60_(ansi|iso)_tsangan_split_bs_shift layouts * shift to rshift * remove 60_ansi_tsangan_split_bs_rshift * Update layouts/default/60_iso_tsangan_split_bs_rshift/info.json * Kisakey (qmk#22217) Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Ryan <fauxpark@gmail.com> * Reword mention of personal keymaps from PR checklist (qmk#22258) * Add support for CSTC40 keyboard (qmk#22154) Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: lesshonor and waffle87 Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: lesshonor Co-authored-by: itsvar <120035196+itsvar8@users.noreply.github.com> * [Keyboard] Add support for EnviousDesign keyboards (qmk#17544) * Add support for Envious.Design Keyboards Add various RP2040 keyboards I've designed. * Fixed missing newlines at EOF. * Ran CLANG-FORMAT and sorted out any potential issues. * Gave keyboards all unique product IDs * Made requested changes. * removed all VIAL related code * sorted out license on all *.h or *.h files * removed outdated RESET Keycode * missed some VIAL bits * Made suggested changes * Made Suggested Changes * missed one file to change. * Attempted fix of CI issues * Update .gitmodules * Revert "Update .gitmodules" This reverts commit f4bace5. * hopefully fixed all CI and QMK lint issues * resolve more CI errors and a couple typos * fixed last remaining issue as of now * made requested changes * further more on suggested change * Delete README.md * derpy workaround to change case of readme * finished up 65M firmware via does not work, I will investigate another time. * re-did a lot of 65M firmware bits, also fixed via for this board * corrected mistake in firmware * made suggested change to info.json for 65m/60F * finished 65M non via keymap and re-sorted via keymap * Update keyboards/enviousdesign/tkl/rgb/keymaps/default/keymap.c * Update keyboards/enviousdesign/tkl/rgb/keymaps/default/keymap.c * Apply suggestions from code review Verified updated Info.json works for aforementioned keyboards, * Follow-up commit with aforementioned suggested changes * Apply suggestions from code review correction to a couple typos pointed out. * follow-up removed some un-needed Readmes and corrected a mistake in 60F via keymap * Apply suggestions from code review * Added images of PCB to each Keyboard README * Apply suggestions from code review * Update keyboards/enviousdesign/60f/readme.md * Added missing aspects of info.json and corrected RGB_DI_PIN to WS2812_DI_PIN in RGB keyboard * made requested changes * Update config.h * used QMK migrate to update info.json * Apply suggestions from code review * Update keyboards/enviousdesign/65m/info.json * renamed named keyboards as suggested and added commission keyboard to repo * renamed file to hopefully please lint * renamed things to be all lower case since lint doesn't appear to look for upper case * updated keymap.c and removed unnecessary file * fixed readme and a couple other bits * converted various aspects to json information * attempt fix for lint error * fix some issues I overlooked * Apply suggestions from code review * moved some folders about as suggested * Made suggested changes * Apply suggestions from code review * removed outdated config.h * fixed errors in 65M and mini1800 * Apply suggestions from code review * Update keyboards/enviousdesign/delirium/rev1/info.json * Update keyboards/enviousdesign/65m/info.json * Apply suggestions from code review * [Keyboard] Skyloong GK61 PRO (qmk#21450) * Add GK61 PRO keyboard * Update info.json regarding to dunk2k suggestion * Update keymap files regarding to dunk2k suggestion * Update keyboards/skyloong/gk61/pro/config.h OK, thanks for your suggestion. * Update keyboards/skyloong/gk61/pro/keymaps/default/keymap.c OK, thanks. * Update keyboards/skyloong/gk61/pro/keymaps/via/keymap.c OK, thanks. * Update keyboards/skyloong/gk61/pro/rules.mk OK, thank you for your suggestion. * Update keyboards/skyloong/gk61/pro/info.json OK,thanks. * Update keyboards/skyloong/gk61/pro/keymaps/default/keymap.c OK, thanks. * Update keyboards/skyloong/gk61/pro/info.json I see , thanks for your guidance. * Update keyboards/skyloong/gk61/pro/config.h OK, thank you. * Update keyboards/skyloong/gk61/pro/info.json OK, thank you for your suggestion. * Update keyboards/skyloong/gk61/pro/info.json I see, thank you. * Update keyboards/skyloong/gk61/pro/config.h OK, thank you for your suggestion. * Update keyboards/skyloong/gk61/pro/pro.c I see , thank you. * Correct PCB feature description in readme. * Update keyboards/skyloong/gk61/pro/config.h It doesn't seem to be a problem to compile without defining DRIVER_COUNT. Thank you for your rigor and seriousness. * Update keyboards/skyloong/gk61/pro/keymaps/default/keymap.c OK, thank you. * update config.h to define __flash. * Update keyboards/skyloong/gk61/pro/config.h I see, thanks for your suggestion. * add hardware availabilty international website * update via/rules.mk for encoder map * Revert "update via/rules.mk for encoder map" This reverts commit 6660124. * Update keyboards/skyloong/gk61/pro/config.h OK, thanks. * Update rules.mk Enable the encoder map. * 1.update readme to correct mcu type ; 2. update pro.c to improve indicator function. * update pro.c and config.h to save power when USB suspend. * update info.json * Update RGB animations---delete rainbow_beacon and rainbow_pinwheels * Update keymap.c and layer indication. * Enable I2C DMA * Update keyboards/skyloong/gk61/pro/info.json OK,Thank you for your suggestion. * Update keyboards/skyloong/gk61/pro/info.json OK,Thanks. * enable encoder map in default keymaps * Update keyboards/skyloong/gk61/pro/info.json OK. Thank you for your suggestion. * [Keyboard] Inland V83P (qmk#21725) * [Keyboard]add v83p keyboard. * Update keymap.c * Update keyboards/inland/v83p/keymaps/via/keymap.c * Update keyboards/inland/v83p/keymaps/default/keymap.c * Update keyboards/inland/v83p/config.h * Update keyboards/inland/v83p/info.json * Update info.json * Update keymap.c * Update keyboards/inland/v83p/mcuconf.h * Update keyboards/inland/v83p/halconf.h * Update keyboards/inland/v83p/info.json * Update keyboards/inland/v83p/v83p.c * Update keymap.c replace the tabs with spaces * Update keymap.c replace the tabs with spaces * Update keyboards/inland/v83p/info.json * [Keyboard] RPNeko65 by lendunistus (qmk#21747) * initialise rpneko65, info.json * force NKRO * define WS2812 stuff and capitalise RPNeko65 * use RGBlight, add ANSI to keymap.c also remove _ADC suffixes from pins * basic readme plus making it so the info.json RGB values are actually recognised as integers * update repository URL * fix info.json formatting * caps lock LED implementation "borrowed" from waffling60 * put RGBLIGHT_ENABLE in json also remove "pin" from the rgblight option * add actually correct keymaps also reformat info.json * move to designer folder, add image to README * move keyboard to separate revision folder and remove erroneous tag from config.h * remove brightness/hue/saturation steps * change device version to 1.0 * move quantum.h include to top * actually, let's try a new image I also forgot to save the info.json file beforehand oops * Remove comma in info.json * Community layouts in info.json * Delete rpneko65/readme.md * Apply suggested changes to readme * Suggested code changes * Suggested imgur link * rename code file this was the issue all along sigh * Correct layer matching this time * Move Enter in info.json * README/info.json change * Another batch of suggestions * [Keyboard] Skyloong GK61 Pro 48 (qmk#21654) * Create GK61 PRO_48 Keyboard. * update pro.c and config.h to save power when USB suspend. * Update keyboards/skyloong/gk61/pro_48/info.json OK,thank you. * update info.json * update layer indicator * Update RGB animations---delete rainbow_beacon and rainbo_pinwheels. * Cancel force_nkro * Add caps lock indicator in rgb matrix. * Update keyboards/skyloong/gk61/pro_48/pro_48.c OK, thank you for your suggestion. * Enable I2C DMA; Modified pro_48.c * Update keyboards/skyloong/gk61/pro_48/info.json OK, thank you for your suggestion. * Update keyboards/skyloong/gk61/pro_48/info.json OK, thanks. * enable encoder map in default keymap. * define g_suspend_state * Dedupe I2C, SPI, UART driver inclusions (qmk#22253) * amend alice* community_layouts in keyboards (qmk#21846) * add alice* to keyboards * add seigaiha * additions * Update info.json * revert wanderland * add tgr/alice * add matrix diagram.md * [Keyboard] Add Okayu (qmk#22077) Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> Co-authored-by: Drashna Jaelre <drashna@live.com> * jian/rev1: convert to DIP Switch (qmk#22248) * Enable encoder map on navpad1.0 (qmk#22266) * [Keyboard] jukaie/jk01 (qmk#20573) * ADD Keyboard * Resolved requested changes * update keymap.c file * resolved requested changes * updated info.json file * Updated requested changes * Delete JK01.h file * Resolved requested changes * Delete readme.md * add rules.mk to default folder * Upload default/keymap.c * Add via/keymap.c * Updated info.Json file * Change VID in info.json * Resolved requested changes * Resolved requested changes. * Resolved requested changes * Updated changes --------- Co-authored-by: gksygithub <gskyGit@gsky.com.tw> * Prep work for NKRO report separation (qmk#22268) * Clean up some keyboard/userspace code * Rename `KEYBOARD_REPORT_BITS` -> `NKRO_REPORT_BITS` * Add some missing includes * Use `PACKED` define for report types * Fix incorrect function signatures for FlexRAM EEPROM driver * Fix typo in keychron v6 encoder map enable (qmk#22272) * Allow for disabling of parallel processing of qmk find and `qmk mass-compile`. (qmk#22160) Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Support additional split sync items for info.json (qmk#22193) * ChibiOS pin defs: use only vendor if present (qmk#22297) * Fixup symbol sizing listing. (qmk#22307) * Migrate recently introduced sync items (qmk#22305) * Rename `DRIVER_ADDR_n` defines (qmk#22200) Co-authored-by: Nick Brassel <nick@tzarc.org> * Fix invalid LED driver config (qmk#22312) * [QP] Add support for OLED, variable framebuffer bpp (qmk#19997) Co-authored-by: Pablo Martínez <58857054+elpekenin@users.noreply.github.com> Co-authored-by: Dasky <32983009+daskygit@users.noreply.github.com> Fixup delta frame coordinates after qmk#20296. * Russian typewriter keymap file for popular legacy layout (qmk#21174) Co-authored-by: Andrei Tutolmin <andrei@tutolmin.com> * Rename LINE FRIENDS TKL keyboard (qmk#22310) * Add `_flush()` functions to LED drivers (qmk#22308) * Modify split config is_keyboard_master/left checks. (qmk#21875) * rework split configuration * Apply suggestions from code review Co-authored-by: Joel Challis <git@zvecr.com> * lint * missed return --------- Co-authored-by: Joel Challis <git@zvecr.com> * Consolidate some EEPROM Driver configuration (qmk#22321) * Separate 6KRO and NKRO report structs (qmk#22267) * [Keyboard] Add purin (qmk#22306) * [Keyboard] Add QK100 (qmk#21782) Co-authored-by: Drashna Jaelre <drashna@live.com> * Remove extra led_matrix_indicators_user call (qmk#22329) * Fix compilation error when led/rgb process limit is zero. (qmk#22328) Co-authored-by: Drashna Jaelre <drashna@live.com> * V-USB: Implement `GET_PROTOCOL` and `SET_PROTOCOL` handling (qmk#22324) * Added gamma values for ST7735 displays (qmk#22313) Co-authored-by: Pablo Martínez <58857054+elpekenin@users.noreply.github.com> Co-authored-by: Nick Brassel <nick@tzarc.org> * Add DD mappings for locking switch (qmk#22242) Co-authored-by: Ryan <fauxpark@gmail.com> * RGB/LED matrix use limits size optimisation (qmk#22325) * [Keyboard] Add LGBTKL (qmk#22331) Co-authored-by: jack <0x6a73@protonmail.com> * Clarify PIO define is optional in docs. (qmk#22339) * V-USB: Fix `GET_IDLE/SET_IDLE` (qmk#22332) Co-authored-by: Sergey Vlasov <sigprof@gmail.com> * [Keyboard] Add Kaly42 (qmk#22282) * Added Kaly/Kaly42 keyboard's minimal files. * Updated readme.md; New link and improved description text. * Apply suggestions from code review Added all suggestions given by @dunk2k Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Added community_layouts to info.json. Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> --------- Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * [Keyboard] add pisces pcb (qmk#22334) * [Keyboard] Waffling60 Rev E ANSI Hotswap (qmk#22270) Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * [Keyboard] Add Waffling60 revision e (qmk#21664) Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> Co-authored-by: Ryan <fauxpark@gmail.com> * Add darkproject/kd87a_bfg_edition keyboard (qmk#18981) Co-authored-by: gksygithub <106651989+gksygithub@users.noreply.github.com> * eason/aeroboard - Modify bootloader (qmk#22286) * [Keyboard] doksin (qmk#22220) * [Maintenance] USB HID control packet as struct (qmk#21688) * ChibiOS: USB HID control request as dedicated struct Instead of accessing the raw USB setup packet and documenting the values as the corresponding USB HID control request fields we introduce a struct that allows direct access to the fields. This is safer and self documenting. * Rename usb_request.h to usb_types.h In the future all shared USB data types can live in this file. * [Keyboard] Add Velvet hotswap & solder (qmk#22284) * Flag more VIAL config options in lint (qmk#22345) * Removed clueboard link as the website has been parked for some time (qmk#22290) * [Keyboard] add enter67 keyboard (qmk#22346) Co-authored-by: “yuezp” <“yuezpchn@126.com”> * Implement data driven dip switches (qmk#22017) * Add data driven dip switches * Autogen weak matrix_mask * QP getters correction (qmk#22357) * Add `_LED_COUNT` defines to LED drivers (qmk#22309) * whitefox: remove pointless file (qmk#22366) * Fix 'to_c' for config.h mappings (qmk#22364) * Remove use of broken split.main (qmk#22363) * Fix for swapped PID and VID (qmk#22372) * Add Kindakeyboards Conone65 Via support (qmk#22320) * Add "AC Next Keyboard Layout Select" consumer usage entry (macOS Globe key) (qmk#22256) * [Keyboard] Add TeaQueen (qmk#22352) Co-authored-by: jack <0x6a73@protonmail.com> * [Keyboard] Add Klein_SD (qmk#22371) Co-authored-by: Joel Challis <git@zvecr.com> * Relocate LED driver init code (qmk#22365) * Add dd mapping for hardware based split handedness (qmk#22369) * Implement data driven lighting defaults (qmk#21825) * Generate switch statement helpers for keycode ranges (qmk#20059) * [Keyboard] matchstickworks/southpad - Move files to rev1, add rev2 (qmk#21574) Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Ryan <fauxpark@gmail.com> * LED drivers: add defines for PWM and LED control register counts (qmk#22383) * Improve argument handling of c2json (qmk#22170) * Improve argument handling of c2json * Add automagic * LED drivers: use `PACKED` define from util.h (qmk#22380) * boardsource/unicorne - Fixed OLED layers being all set to zero (qmk#22389) * docs(rgblight): fix typos (qmk#22399) * Allow generic_features to handle subdirectories (qmk#22400) * Teaqueen: correct layout data (qmk#22406) * [Keyboard] Add Piantor Pro (qmk#22361) Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> Co-authored-by: jack <0x6a73@protonmail.com> * WT RGB cleanups (qmk#22379) * Red Herring PCB support (qmk#22409) Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com> Co-authored-by: jack <0x6a73@protonmail.com> * Add riblee handwired split keyboard (qmk#22277) * [Keyboard] Add Duet Switch Tester (qmk#22367) Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Drashna Jaelre <drashna@live.com> * [Keyboard] Add PCB Utopia88 (qmk#22257) * feat(mechwild/clunker): new layouts (qmk#22342) * Fix Herringbone pro Layouts (qmk#22317) Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * [Keyboard] Rename soda/{mango,pocket} (qmk#22151) Co-authored-by: Joel Challis <git@zvecr.com> * Add iso85k keyboard (qmk#22411) Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Fix corne keylog (qmk#22420) * [Keyboard] Fix bug in set_keylog function Fixes issue where some keys would not trigger the oled to output the row and column of a pressed key (would happen with LT(...) for my keymap) * [Keyboard] Tiny improvement to oled_render_keylog for crkbd Added improvement suggestion I got for another keyboard * Fix indicator LED definition for Sofle RGB. (qmk#22408) * Migrate some common features to generic (qmk#22403) * Update layer state of Lily58 from 'Default' to 'Base' (qmk#22397) * Add SNES Macropad keyboard (qmk#22377) Co-authored-by: jack <0x6a73@protonmail.com> * Update gregandcin/teaqueen (qmk#22402) * [Keyboard] Add alpaca/wfeclipse (qmk#22230) Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: Drashna Jaelre <drashna@live.com> * LED drivers: clean up `SWx`/`CSy` pullup/down resistor config (qmk#22381) * Infer LED DRIVER_COUNT from configured addresses (qmk#22311) * Add Ploopy Madromys mouse (qmk#21989) Added PloopyCo madromys/adept mouse Co-authored-by: Drashna Jaelre <drashna@live.com> * [Keyboard] Add MariOrion v2.5 (qmk#22273) * Pushed MariOrion v2.5 to the branch. Prod and proto version added. * Pushed MariOrion v2.5 to the branch. Prod and proto version added. * Proper addition of layout options Addition of split bs rshift tsangan layout options. Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Merge branch 'toril940mariorion_v25' of github.com:toril940/qmk_firmware into toril940mariorion_v25 * Merge branch 'toril940mariorion_v25' of github.com:toril940/qmk_firmware into toril940mariorion_v25 * Update keyboards/mariorion_v25/proto/keymaps/via/keymap.c Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Update keyboards/mariorion_v25/proto/keymaps/default/keymap.c Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Updated readme.md with more information regarding make commands, and proto vs prod. * Update keyboards/mariorion_v25/prod/keymaps/via/keymap.c Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Update keyboards/mariorion_v25/prod/keymaps/default/keymap.c Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Update keyboards/mariorion_v25/prod/info.json Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Amended some changes to info.json - community layouts changed from scope to array. * Update keyboards/mariorion_v25/readme.md Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Revert keyboards/gray_studio/think65/solder/solder.c Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Revert keyboards/gray_studio/think65/solder/solder.c Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Revert keyboards/gray_studio/think65/solder/solder.c Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Removed via.json from the via keymaps. Replaced with matrix_diagram.md. via.json file moved off to [public mariorion_v25 repo](https://github.com/toril940/orion-v25) * Revert keyboards/gray_studio/think65/solder/solder.c Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Removed via.json from the via keymaps. Replaced with matrix_diagram.md. via.json file moved off to [public mariorion_v25 repo](https://github.com/toril940/orion-v25) * Update keyboards/mariorion_v25/proto/info.json Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Update keyboards/mariorion_v25/rules.mk Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Update keyboards/mariorion_v25/proto/info.json Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Update keyboards/mariorion_v25/proto/info.json Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Update keyboards/mariorion_v25/proto/info.json Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Update keyboards/mariorion_v25/prod/info.json Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Update keyboards/mariorion_v25/prod/info.json Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Update keyboards/mariorion_v25/prod/info.json Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Update keyboards/mariorion_v25/prod/info.json Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Revert keyboards/gray_studio/think65/solder/solder.c Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Update keyboards/mariorion_v25/matrix_diagram.md Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Update keyboards/mariorion_v25/readme.md Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Update keyboards/mariorion_v25/readme.md Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Update keyboards/mariorion_v25/readme.md Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Update keyboards/mariorion_v25/readme.md Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Update keyboards/mariorion_v25/readme.md Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Update keyboards/mariorion_v25/proto/mariorion_v25.c Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Update keyboards/mariorion_v25/prod/mariorion_v25.c Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Pushed new info.json and keymap.c files. * Pushed new info.json and keymap.c files. * Fixes to LED driver wrt PWM definitions with STM. * Update keyboards/mariorion_v25/prod/keymaps/via/keymap.c Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/mariorion_v25/prod/keymaps/via/keymap.c Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/mariorion_v25/prod/info.json Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/mariorion_v25/prod/mariorion_v25.c Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/mariorion_v25/proto/info.json Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/mariorion_v25/proto/config.h Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/mariorion_v25/proto/mariorion_v25.c Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/mariorion_v25/proto/mariorion_v25.c Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/mariorion_v25/proto/keymaps/via/keymap.c Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/mariorion_v25/proto/keymaps/via/keymap.c Co-authored-by: Ryan <fauxpark@gmail.com> * Committing a details update to readme.md. * Committing a details update to readme.md. * Update keyboards/mariorion_v25/prod/config.h Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/mariorion_v25/prod/mariorion_v25.c Co-authored-by: Ryan <fauxpark@gmail.com> * Revert "Committing a details update to readme.md." This reverts commit 068a82a. * Committing a details update to readme.md. * Update keyboards/mariorion_v25/halconf.h Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/mariorion_v25/mcuconf.h Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/mariorion_v25/prod/config.h Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/mariorion_v25/proto/config.h Co-authored-by: Ryan <fauxpark@gmail.com> * Update keyboards/mariorion_v25/halconf.h Co-authored-by: Ryan <fauxpark@gmail.com> * Production pictures replacing the standard ones in the readme.md :) * waffle87 requests bundled: - Licence headers added - Codeblocked matrix_diagram.md - Consolidated files where possible - Removed excess from config.h --------- Co-authored-by: toril940 <anastasialucas940@hotmail.com> Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> Co-authored-by: Ryan <fauxpark@gmail.com> * snled27351: fix missing `i2c_init()` (qmk#22446) * Fixup snes_macropad on develop (qmk#22444) * Add `qmk license-check` developer-level CLI command. (qmk#22075) * fix: make clicky delay silent (qmk#21866) * add 5087 keyboard (qmk#20557) Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com> * studiokestra/line_tkl: correct layout data (qmk#22455) * fix `layouts` data * add EoF * [Keyboard] Fixes to make snes_macropad play nicer with qmk configurator (qmk#22432) * [Keyboard] Change default implementation for get_layer_name_user Will now show the layer number instead of "Unknown", since this is what will be shown if QMK Configurator is used to compile the firmware. * [Keyboard] Update the layout info This makes it look sort of like a macropad + gamepad rather than an 4x6 ortholinear keyboard. * [Keyboard] Fix default implementation of get_layer_name_user Based on feedback from code review the implementation was swapped in favor of using get_u8_str. This implied a change to the argument type from int to uint8_t, which cascaded into the existing keymaps. (This made sense in general, since the return type of get_highest_layer is also a uint8_t.) * Slight refactor of joystick axis type into typedef (qmk#22445) * Remove requirement for `keymap_steno.h` include in keymaps (qmk#22423) * Remove requirement for `keymap_steno.h` include in keymaps * Add back keymap_steno.h with a note for the time being * Generalise ADC driver source inclusion (qmk#22448) * add `68_ansi` Community Layout to nebula68b (qmk#22433) * Fix typos: key-modifer→key-modifier and interacton→interaction (qmk#22464) * chibios: disable RWX segment warning on newer GNU lds (qmk#22007) * Migrate some EEPROM config to info.json (qmk#22434) * Revert "chibios: disable RWX segment warning on newer GNU lds (qmk#22007)" (qmk#22469) This reverts commit de3c421. * chibios: disable RWX segment warning on newer GNU lds (qmk#22471) * Bs equals (qmk#21690) Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: jack <0x6A73@pm.me> * Update stale.yml (qmk#22473) * Update stale.yml * [Keyboard] Add Eden (qmk#22467) Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * CLI refactoring for common build target APIs (qmk#22221) * Add leonardo build target for leonardo + usb2.0 shield based projects (qmk#22243) * [Keyboard] Add dnworks 997pt3 (qmk#22466) Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com> Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * [Doc] Improve converter references (qmk#21801) * `qmk find`: Fix failure with multiple filters (qmk#22497) When multiple `-f FILTER` options were specified, `qmk find` did not return anything at all instead of printing the list of entries that matched all of the specified filters. The problem was that the statement in `_filter_keymap_targets()` that filled `targets` had a wrong indent and therefore was executed for every filter instead of only once after applying all filters, and `valid_keymaps` was actually an iterator and therefore could be used only once. Moving the statement outside of the loop fixes the problem. * Enable linking of encoders to switch within layout macros (qmk#22264) * LED drivers: register naming cleanups (qmk#22436) * Azoteq IQS5xx support (qmk#22280) * Fix `qmk find` failure due to circular imports (qmk#22523) There was an import cycle in the Python modules: - `qmk.build_targets` imported `qmk.cli.generate.compilation_database`; - importing `qmk.cli.generate.compilation_database` requires initializing `qmk.cli` first; - the initialization of `qmk.cli` imported the modules for all CLI commands; - `qmk.cli.compile` imported `qmk.build_targets`. This cycle did not matter in most cases, because `qmk.cli` was imported first, and in that case importing `qmk.cli.generate.compilation_database` did not trigger the initialization of `qmk.cli` again. However, there was one corner case when `qmk.bulld_targets` was getting imported first: - The `qmk find` command uses the `multiprocessing` module. - The `multiprocessing` module uses the `spawn` start method on macOS and Windows. - When the `spawn` method is used, the child processes initialize without any Python modules loaded, and the required modules are loaded on demand by the `pickle` module when receiving the serialized objects from the main process. The result was that the `qmk find` command did not work properly on macOS (and probably Windows too); it reported exceptions like this: ImportError: cannot import name 'KeyboardKeymapBuildTarget' from partially initialized module 'qmk.build_targets' (most likely due to a circular import) Moving the offending `qmk.cli.generate.compilation_database` import into the method which actually uses it fixes the problem. * CLI parallel search updates (qmk#22525) * Move BACKLIGHT_PWM_PERIOD to correct docs section (qmk#22480) * [CLI] Remove duplicates from search results (qmk#22528) * Add simpler method for relocating functions to RAM. (qmk#21804) * Migrate some dip switch config to info.json (qmk#22437) * Remove unnecessary driver counts (qmk#22435) * [Keyboard] darkproject/kd83a_bfg_edition (qmk#18416) * Add files via upload * [keyboard] * [Keyboard] * Delete flash_spi.c * Delete flash_spi.h * Delete wb32_spi_master.c * Delete wb32_spi_master.h * [Keyboard] * Resolved requested changes * Resolved requested changes * Changed rules.mk file accordingly. * Resolved changes accordingly. * Update config.h file and rules.mk file * Removed eeprom_flash.c file * Update default/keymap.c file * Delete keyboards/darkproject/kd83a_bfg_edition directory * Add keyboard * Add keyboard * Delete darkproject/kd83a_bfg_edition directory * Resolved Changes * Resolved requested changes * keyboard * Add keyboard * Delete keyboard * Add keyboard * Delete keyboards/darkproject/kd87a_bfg_edition directory * update keymap.c file * update via/keymap.c, config.h and kd83a_bfg_edition.c files * Delete keymap.c * Update via/keymap.c, config.h and kd83a_bfg_edition.c files * update config.h file * update keymap.c file * update keymap.c file * update config.h * update kd83a_bfg_edition.c * Resolved requested changes. * Delete folder which was added accidentally. * Update keyboards/darkproject/kd83a_bfg_edition/config.h * Update keyboards/darkproject/kd83a_bfg_edition/keymaps/via/keymap.c * Update keyboards/darkproject/kd83a_bfg_edition/keymaps/via/keymap.c * Update keyboards/darkproject/kd83a_bfg_edition/keymaps/via/keymap.c * Update keyboards/darkproject/kd83a_bfg_edition/keymaps/via/keymap.c * Update keyboards/darkproject/kd83a_bfg_edition/info.json * Update keyboards/darkproject/kd83a_bfg_edition/rules.mk * Update keyboards/darkproject/kd83a_bfg_edition/info.json * update info.json file * update config.h file * Updated requested changes * update readme.md * Resolved requested changes * Update info.json file * Delete kd83a_bfg_edition.h * Delete readme.md in default folder * Update info.json file * update info.json * Updated changes * Updated changes * Resolved requested changes * Resolved requested changes * DC60: Fix 2u Backspace Support (qmk#22533) * V-USB: Add generic `send_report()` function (qmk#22323) * V-USB: implement NKRO (qmk#22398) * Improve and Cleanup Shutdown callbacks (qmk#21060) Co-authored-by: Dasky <32983009+daskygit@users.noreply.github.com> * Cater for ECC failures in EFL wear-leveling. (qmk#19749) Co-authored-by: Sergey Vlasov <sigprof@gmail.com> * New RGB Animations - 4 "Starlight" Animation Variations (qmk#22212) * Stub out community layout directory structure (qmk#22545) * Remove userspace keymaps (qmk#22544) * Remove symbolic linked userspace folder (qmk#22548) * Fix missed shutdown callbacks (qmk#22549) * QMK Userspace (qmk#22222) Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * `develop` 2023q4 changelog (qmk#22552) Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Ryan <fauxpark@gmail.com> * Remove notice about `develop`. * Attempt to fix configurator. (qmk#22555) * Bump JamesIves/github-pages-deploy-action from 4.4.3 to 4.5.0 (qmk#22559) Bumps [JamesIves/github-pages-deploy-action](https://github.com/jamesives/github-pages-deploy-action) from 4.4.3 to 4.5.0. - [Release notes](https://github.com/jamesives/github-pages-deploy-action/releases) - [Commits](JamesIves/github-pages-deploy-action@v4.4.3...v4.5.0) --- updated-dependencies: - dependency-name: JamesIves/github-pages-deploy-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Small QP surface docs update (qmk#22567) * Fixup compilation with `qmk compile -kb zzz -km all`. (qmk#22568) * [Doc]: Correct Markdown syntax errors. (qmk#22511) * cablecardesigns/phoenix: correct layout data (qmk#22517) * add tokki (qmk#22463) Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Add ScottoWing handwired keyboard (qmk#22506) Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Add Magnum Ergo 1 by dark (qmk#22139) Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Add Smith and Rune Magnus (qmk#22153) Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com> Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Fixup `--no-temp` for `qmk mass-compile`. (qmk#22582) * nullbitsco/snap: reduce size of bongo_reactive (qmk#22571) * revoke community_layouts from keebio/wtf60 (qmk#22502) * add keyboard bestway (qmk#22498) Co-authored-by: “yuezp” <“yuezpchn@126.com”> * Fix animation range on M75H (qmk#22586) * Fix a bunch of CLI warnings (qmk#22589) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: QMK Bot <hello@qmk.fm> Co-authored-by: Arthur <37627147+ArthurCyy@users.noreply.github.com> Co-authored-by: jonylee@hfd <108282809+jonylee1986@users.noreply.github.com> Co-authored-by: Dasky <32983009+daskygit@users.noreply.github.com> Co-authored-by: Josh Hinnebusch <joshhinnebusch@gmail.com> Co-authored-by: ClicketySplit <101202583+ClicketySplit@users.noreply.github.com> Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> Co-authored-by: Agent Blu, 006 <blu006@ucr.edu> Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: 4pplet <mail@4pplet.com> Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: 4pplet <4pplet@protonmail.com> Co-authored-by: 4pplet <stefan.ess@gmail.com> Co-authored-by: Alin Marin Elena <alin@elena.space> Co-authored-by: adam tombleson <rekarnar@gmail.com> Co-authored-by: kisakey-luxury <143060353+kisakey-luxury@users.noreply.github.com> Co-authored-by: Wilhelm Schuster <ws@rot13.io> Co-authored-by: Felipe Curty <felipecrp@gmail.com> Co-authored-by: itsvar <120035196+itsvar8@users.noreply.github.com> Co-authored-by: EnviousData <Enviousdata@gmail.com> Co-authored-by: skyloong <92424712+JZ-Skyloong@users.noreply.github.com> Co-authored-by: lendunistus <53618962+lendunistus@users.noreply.github.com> Co-authored-by: Sắn <59417802+MaiTheSan@users.noreply.github.com> Co-authored-by: MakotoKurauchi <pluis@me.com> Co-authored-by: jukaie <131839249+jukaie@users.noreply.github.com> Co-authored-by: gksygithub <gskyGit@gsky.com.tw> Co-authored-by: Nick Brassel <nick@tzarc.org> Co-authored-by: Andrey Tutolmin <45759479+tutolmin@users.noreply.github.com> Co-authored-by: Andrei Tutolmin <andrei@tutolmin.com> Co-authored-by: studiokestra <74369928+studiokestra@users.noreply.github.com> Co-authored-by: Yonghyuk Choi <42003350+oRE-o@users.noreply.github.com> Co-authored-by: owlab-git <88034417+owlab-git@users.noreply.github.com> Co-authored-by: Rakib Shahid <95511504+rakib-shahid@users.noreply.github.com> Co-authored-by: Pablo Martínez <58857054+elpekenin@users.noreply.github.com> Co-authored-by: jack <0x6A73@pm.me> Co-authored-by: Olivia J <65928618+ojthetiny@users.noreply.github.com> Co-authored-by: Sergey Vlasov <sigprof@gmail.com> Co-authored-by: Kael Augusto <45074062+Dwctor@users.noreply.github.com> Co-authored-by: khchen2004 <148961563+khchen2004@users.noreply.github.com> Co-authored-by: gskygithub <106651989+gskygithub@users.noreply.github.com> Co-authored-by: gksygithub <106651989+gksygithub@users.noreply.github.com> Co-authored-by: eason <98533237+EasonQian1@users.noreply.github.com> Co-authored-by: millet <49581988+milletmilletmilletmilletmilletmilletmil@users.noreply.github.com> Co-authored-by: Stefan Kerkmann <karlk90@pm.me> Co-authored-by: Felix Jen <fjen@felixjen.com> Co-authored-by: Brian Choromanski <BrianChoromanski@gmail.com> Co-authored-by: yuezp <49514776+LXF-YZP@users.noreply.github.com> Co-authored-by: “yuezp” <“yuezpchn@126.com”> Co-authored-by: David Hoelscher <infinityis@users.noreply.github.com> Co-authored-by: Cipulot <40441626+Cipulot@users.noreply.github.com> Co-authored-by: Matt Chan <5021+mattchan@users.noreply.github.com> Co-authored-by: gregandcin <gregandcinbusiness@gmail.com> Co-authored-by: era <73109780+eerraa@users.noreply.github.com> Co-authored-by: Logan Butler <8854426+MatchstickWorks@users.noreply.github.com> Co-authored-by: ID64F <54159272+ID64F@users.noreply.github.com> Co-authored-by: Kiryl Mialeshka <8974488+meskill@users.noreply.github.com> Co-authored-by: Leo Lou <louyuhong@gmail.com> Co-authored-by: Ming-Gih Lam <dcpedit@hotmail.com> Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com> Co-authored-by: Reibl János Dániel <janos.daniel.reibl@protonmail.com> Co-authored-by: ai03 <admin@ai03.com> Co-authored-by: Kelwin0313 <139501176+Kelwin0313@users.noreply.github.com> Co-authored-by: Yak <68242321+yakMM@users.noreply.github.com> Co-authored-by: Jeayo Keh <gezhaoyou@126.com> Co-authored-by: Fredrik A. Kristiansen <fredrikaxk@gmail.com> Co-authored-by: John Barbero <john@lsrkttn.com> Co-authored-by: Matthias Liffers <m@tthi.as> Co-authored-by: Panos Sakkos <panos.sakkos@gmail.com> Co-authored-by: temp4gh <temp4bbs@163.com> Co-authored-by: ploopyco <54917504+ploopyco@users.noreply.github.com> Co-authored-by: Maria <81305596+toril940@users.noreply.github.com> Co-authored-by: toril940 <anastasialucas940@hotmail.com> Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com> Co-authored-by: John Barbero <git@lsrkttn.com> Co-authored-by: precondition <57645186+precondition@users.noreply.github.com> Co-authored-by: Thomas Weißschuh <thomas@t-8ch.de> Co-authored-by: cole smith <38364556+daysgobye@users.noreply.github.com> Co-authored-by: leyew <102467346+itsme-zeix@users.noreply.github.com> Co-authored-by: Le Zhang <lzhang10@users.noreply.github.com> Co-authored-by: フィルターペーパー <76888457+filterpaper@users.noreply.github.com> Co-authored-by: db <108231591+bactaholic@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: 猫咪恐慌 <30993222+kitty-panics@users.noreply.github.com> Co-authored-by: Alabahuy <rezolutionrez@gmail.com> Co-authored-by: Joe Scotto <8194147+joe-scotto@users.noreply.github.com> Co-authored-by: Álvaro A. Volpato <alvaro.augusto.volpato@gmail.com> Co-authored-by: Jay Greco <jayv.greco@gmail.com>
zgagnon
pushed a commit
to zgagnon/qmk_firmware_waterfowl
that referenced
this pull request
Dec 15, 2023
future-figs
pushed a commit
to future-figs/qmk_firmware
that referenced
this pull request
Dec 27, 2023
mute-civilian
pushed a commit
to mute-civilian/qmk_firmware
that referenced
this pull request
Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Nothing works in this area anyway - the plan is still to rework everything with something like #18254. Keyboard changes,
"main": "left"- redundant as default behaviour anyway"main": "matrix_grid"- set on boards using SPLIT_HAND_PIN"main": "pin"- does nothing as dependent logic is stillconfig.hAdditional changes around 18254 incoming shortly after this PR.
Types of Changes
Issues Fixed or Closed by This PR
Checklist