Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add APA102_LED_COUNT define #22530

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Add APA102_LED_COUNT define #22530

merged 1 commit into from
Nov 29, 2023

Conversation

fauxpark
Copy link
Member

Description

To match the rest of the LED drivers (particularly WS2812). No usages yet but will have in future; related to #22529.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team November 22, 2023 07:04
@drashna drashna requested a review from a team November 29, 2023 02:08
@fauxpark fauxpark merged commit 099eaef into qmk:develop Nov 29, 2023
3 checks passed
@fauxpark fauxpark deleted the apa102-led-count branch November 29, 2023 23:19
itsjonny96 pushed a commit to itsjonny96/qmk_firmware that referenced this pull request Jan 7, 2024
@fauxpark @itsjonny96
Add APA102_LED_COUNT define (qmk#22530)
fd43734
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 17, 2024
@fauxpark @mechlovin
Add APA102_LED_COUNT define (qmk#22530)
c42ebaf
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 19, 2024
@fauxpark @mechlovin
Add APA102_LED_COUNT define (qmk#22530)
be414ea
Mesabloo pushed a commit to Mesabloo/qmk_firmware that referenced this pull request May 27, 2024
@fauxpark @Mesabloo
Add APA102_LED_COUNT define (qmk#22530)
3296880
AJO-Python pushed a commit to AJO-Python/qmk_firmware that referenced this pull request Jul 7, 2024
@fauxpark @AJO-Python
Add APA102_LED_COUNT define (qmk#22530)
26d1e5c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fauxpark @drashna