Skip to content

Update Q5 #22575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 1, 2024
Merged

Update Q5 #22575

merged 9 commits into from
Feb 1, 2024

Conversation

adophoxia
Copy link
Contributor

@adophoxia adophoxia commented Nov 30, 2023 •
edited
Loading

Description

Superseeds #21423, but this will only cover one board from each series update of PRs. Also enables Num Lock Indicator LED.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • N/A

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

lesshonor
lesshonor suggested changes Nov 30, 2023
View reviewed changes
@adophoxia @lesshonor
Update keyboards/keychron/q5/readme.md
983743a 
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
zvecr
zvecr reviewed Nov 30, 2023
View reviewed changes
@drashna drashna requested a review from a team December 5, 2023 04:20
fauxpark
fauxpark requested changes Dec 5, 2023
View reviewed changes
@drashna drashna merged commit 252f01f into qmk:develop Feb 1, 2024
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@adophoxia @lesshonor
@zvecr @fauxpark @nuess0r
[Keyboard] Update Keychron Q5 (qmk#22575)
8f54a71 
Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
@adophoxia adophoxia deleted the update-q5 branch January 29, 2025 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr left review comments

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

+1 more reviewer

@lesshonor lesshonor lesshonor requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adophoxia @drashna @fauxpark @zvecr @lesshonor