Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant rgblight eeconfig init #22674

Merged
merged 1 commit into from
Dec 16, 2023
Merged

Remove redundant rgblight eeconfig init #22674

merged 1 commit into from
Dec 16, 2023

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Dec 15, 2023

Description

Extracted from #12020, as a more digestible chunk.

With the overall aim to remove all inits, magic() is now called before rgblight_init so the one removed here are no longer required.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Dec 15, 2023
@zvecr zvecr merged commit f165eb5 into qmk:develop Dec 16, 2023
4 checks passed
itsjonny96 pushed a commit to itsjonny96/qmk_firmware that referenced this pull request Jan 7, 2024
@zvecr @itsjonny96
Remove redundant rgblight eeconfig init (qmk#22674)
12870eb
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 17, 2024
@zvecr @mechlovin
Remove redundant rgblight eeconfig init (qmk#22674)
c03032b
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 19, 2024
@zvecr @mechlovin
Remove redundant rgblight eeconfig init (qmk#22674)
bb4c6bf
Mesabloo pushed a commit to Mesabloo/qmk_firmware that referenced this pull request May 27, 2024
@zvecr @Mesabloo
Remove redundant rgblight eeconfig init (qmk#22674)
7db27a4
AJO-Python pushed a commit to AJO-Python/qmk_firmware that referenced this pull request Jul 7, 2024
@zvecr @AJO-Python
Remove redundant rgblight eeconfig init (qmk#22674)
c327ece
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
core enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zvecr @drashna @fauxpark