Remove redundant backlight eeconfig init #22675
Merged
+15
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
approved these changes
Dec 16, 2023
itsjonny96
pushed a commit
to itsjonny96/qmk_firmware
that referenced
this pull request
Jan 7, 2024
mechlovin
pushed a commit
to mechlovin/qmk_firmware
that referenced
this pull request
Jan 17, 2024
mechlovin
pushed a commit
to mechlovin/qmk_firmware
that referenced
this pull request
Jan 19, 2024
nuess0r
pushed a commit
to nuess0r/qmk_firmware
that referenced
this pull request
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extracted from #12020, as a more digestible chunk.
With the overall aim to remove all inits,
magic()is now called beforebacklight_init. eeprom will always be valid by the timebacklight_initis called. Because of this, the existing logic to default config is currently broken.The spare bit in the eeprom config has been used to decide if the backlight eeprom init process has been completed.
Types of Changes
Issues Fixed or Closed by This PR
Checklist