Skip to content

[Audio] Enable Complementary output for PWM Hardware driver #22726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 22, 2023
Merged

[Audio] Enable Complementary output for PWM Hardware driver #22726

merged 3 commits into from
Dec 22, 2023

Conversation

drashna
Copy link
Member

@drashna drashna commented Dec 20, 2023

Description

Adds support for PWM complementary output for the PWM Hardware audio driver.

Tested on STM32F405.

Types of Changes

  • Core
  • Enhancement/optimization
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna requested a review from a team December 20, 2023 23:08
zvecr
zvecr reviewed Dec 21, 2023
View reviewed changes
@drashna @zvecr
fix typo
f3f2dd6 
Co-authored-by: Joel Challis <git@zvecr.com>
zvecr
zvecr reviewed Dec 21, 2023
View reviewed changes
sigprof
sigprof requested changes Dec 21, 2023
View reviewed changes
@drashna drashna requested review from sigprof and a team December 21, 2023 17:30
@drashna drashna merged commit 29f8fa3 into qmk:develop Dec 22, 2023
@drashna drashna deleted the audio/comp branch December 22, 2023 03:47
@drashna drashna mentioned this pull request Jan 5, 2024
Merged
10 tasks
itsjonny96 pushed a commit to itsjonny96/qmk_firmware that referenced this pull request Jan 7, 2024
@drashna @zvecr @itsjonny96
[Audio] Enable Complementary output for PWM Hardware driver (qmk#22726)
72a129f 
Co-authored-by: Joel Challis <git@zvecr.com>
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 17, 2024
@drashna @zvecr @mechlovin
[Audio] Enable Complementary output for PWM Hardware driver (qmk#22726)
9f46f6f 
Co-authored-by: Joel Challis <git@zvecr.com>
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 19, 2024
@drashna @zvecr @mechlovin
[Audio] Enable Complementary output for PWM Hardware driver (qmk#22726)
358c9e7 
Co-authored-by: Joel Challis <git@zvecr.com>
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@drashna @zvecr @nuess0r
[Audio] Enable Complementary output for PWM Hardware driver (qmk#22726)
2b359d4 
Co-authored-by: Joel Challis <git@zvecr.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@zvecr zvecr zvecr approved these changes

@sigprof sigprof Awaiting requested review from sigprof

Assignees
No one assigned
Labels
core documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@drashna @sigprof @fauxpark @zvecr