[Audio] Add support for audio shutdown pin #22731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fauxpark
requested changes
Dec 21, 2023
Co-authored-by: Ryan <fauxpark@gmail.com>
drashna
force-pushed
the
audio/shutdown_pin
branch
from
d309577
to
619c141
Compare
drashna
force-pushed
the
audio/shutdown_pin
branch
from
98a32cb
to
faed692
Compare
tzarc
approved these changes
Jan 9, 2024
zvecr
reviewed
Jan 9, 2024
Wasn't sure about the naming, but yeah, enable pin is more accurate for the functionality. |
drashna
commented
Jan 9, 2024
data/schemas/keyboard.jsonschema
Outdated
| @@ -133,6 +133,14 @@ | |||
| }, | |||
| "macro_beep": {"type": "boolean"}, | |||
| "pins": {"$ref": "qmk.definitions.v1#/mcu_pin_array"}, | |||
| "enable_pin": { | |||
There was a problem hiding this comment.
I'm not really happy with the name, but audio.enable just doesn't seem right.
There was a problem hiding this comment.
power_control perhaps?
audio.power_control.pin, audio.power_control.on_state, etc.
There was a problem hiding this comment.
Yeah, that's a much better name. Updated names.
tzarc
added
breaking_change_2024q2
develop-fast-track
tzarc
approved these changes
Mar 6, 2024
mechlovin
pushed a commit
to mechlovin/qmk_firmware
that referenced
this pull request
Apr 4, 2024
Co-authored-by: Ryan <fauxpark@gmail.com>
mechlovin
pushed a commit
to mechlovin/qmk_firmware
that referenced
this pull request
Apr 4, 2024
Co-authored-by: Ryan <fauxpark@gmail.com>
mechlovin
pushed a commit
to mechlovin/qmk_firmware
that referenced
this pull request
Apr 15, 2024
Co-authored-by: Ryan <fauxpark@gmail.com>
0x647262
pushed a commit
to 0x647262/qmk_firmware
that referenced
this pull request
Apr 26, 2024
Co-authored-by: Ryan <fauxpark@gmail.com>
PepperLola
pushed a commit
to PepperLola/qmk_firmware
that referenced
this pull request
May 29, 2024
Co-authored-by: Ryan <fauxpark@gmail.com>
whoisjordangarcia
pushed a commit
to whoisjordangarcia/qmk_firmware
that referenced
this pull request
Jun 8, 2024
Co-authored-by: Ryan <fauxpark@gmail.com>
nuphy-src
pushed a commit
to nuphy-src/qmk_firmware
that referenced
this pull request
Jul 2, 2024
Co-authored-by: Ryan <fauxpark@gmail.com>
AJO-Python
pushed a commit
to AJO-Python/qmk_firmware
that referenced
this pull request
Jul 7, 2024
Co-authored-by: Ryan <fauxpark@gmail.com>
jrtex
pushed a commit
to jrtex/qmk_firmware
that referenced
this pull request
Jul 13, 2024
Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support to core code for controlling shutdown pin for the audio driver. This is useful when using an amp like the PAM8302 2.5W class D amp from adafruit.
Types of Changes
Checklist