Skip to content

Flag invalid keyboard features during lint #22832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 8, 2024
Merged

Flag invalid keyboard features during lint #22832

merged 1 commit into from
Feb 8, 2024
+15 −0

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jan 5, 2024 •
edited
Loading

Description

While submitters will continue to ignore the CI status, something is better than nothing.

Alternative/addition for failure at compile time.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added python cli qmk cli command labels Jan 5, 2024
@drashna drashna requested a review from a team January 7, 2024 06:45
@tzarc
Copy link
Member

tzarc commented Jan 8, 2024

Happy to go with failure option, personally.

@zvecr zvecr changed the base branch from master to develop February 8, 2024 06:33
@zvecr zvecr merged commit e7b84e1 into qmk:develop Feb 8, 2024
@zvecr zvecr deleted the lint_invalid_kb_features branch February 8, 2024 06:34
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@zvecr @nuess0r
Flag invalid keyboard features during lint (qmk#22832)
5943462
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
cli qmk cli command enhancement python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zvecr @tzarc @drashna