Skip to content

LED drivers: remove write_pwm_buffer() from public API #22884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 23, 2024
Merged

LED drivers: remove write_pwm_buffer() from public API #22884

merged 5 commits into from
Jan 23, 2024

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Jan 11, 2024 •
edited
Loading

Description

This function is completely useless for consumers as you should never supplant the internal g_pwm_buffer with one of your own.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team January 11, 2024 02:27
@drashna drashna requested a review from a team January 23, 2024 19:27
@fauxpark fauxpark merged commit d96ac70 into qmk:develop Jan 23, 2024
@fauxpark fauxpark deleted the led-drivers-write-pwm-buffer branch January 23, 2024 22:18
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@fauxpark @nuess0r
LED drivers: remove write_pwm_buffer() from public API (qmk#22884)
0bae7e7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core enhancement keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fauxpark @drashna