Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate content where only parent info.json exists #22895

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jan 12, 2024

Description

Keyboards discovered with the following...

# asdf/info.json
# asdf/rev1/rules.mk
# asdf/rev2/rules.mk
for kb in $(qmk list-keyboards); do
    if [[ -f keyboards/${kb}/rules.mk && ! -f keyboards/${kb}/info.json ]]; then
        if [[ -f keyboards/${kb}/rules.mk && ! -s keyboards/${kb}/rules.mk ]]; then
            true
        elif grep -q "intentionally left blank" keyboards/${kb}/rules.mk; then
            true
        else
            echo "TODO: keyboards/${kb}/rules.mk"
            # cat keyboards/${kb}/rules.mk
        fi
    fi
done

Candidates flagged as TODO are those that can not easily be migrated for #22891.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Copy link
Contributor

@lesshonor lesshonor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All SHAs except those for the bpiphany/frosty_flake keymaps match against 548983a, either without any changes or when the changes to features are replicated.

Matched full stop:
canary/canary60rgb/v1
mechwild/sugarglider/*
melgeek/mojo68
melgeek/mojo75
melgeek/tegic
melgeek/z70ultra

Matched after feature changes were replicated:
handwired/qc60/proto - enabled bootmagic and mousekeys
handwired/stef9998/split_5x7/rev1 - enabled bootmagic, disabled command
murcielago/rev1:default - enabled bootmagic
polilla/rev1 - enabled bootmagic and mousekeys
spacetime/rev1 - enabled bootmagic, disabled console
spacetime/rev2 - enabled bootmagic, disabled console
xiudi/xd004/v1 - enabled space cadet

Aside from enabling bootmagic, I'm going to assume the mismatch is because both Frosty Flake keyboards currently write one wrong LED high during pre-init (oops) and call it there.

Copy link

github-actions bot commented Mar 7, 2024

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Mar 7, 2024
@zvecr zvecr added awaiting review and removed stale Issues or pull requests that have become inactive without resolution. labels Mar 7, 2024
@tzarc tzarc merged commit aea414f into develop Mar 14, 2024
2 of 3 checks passed
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Apr 4, 2024
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Apr 4, 2024
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Apr 15, 2024
0x647262 pushed a commit to 0x647262/qmk_firmware that referenced this pull request Apr 26, 2024
PepperLola pushed a commit to PepperLola/qmk_firmware that referenced this pull request May 29, 2024
whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
nuphy-src pushed a commit to nuphy-src/qmk_firmware that referenced this pull request Jul 2, 2024
AJO-Python pushed a commit to AJO-Python/qmk_firmware that referenced this pull request Jul 7, 2024
jrtex pushed a commit to jrtex/qmk_firmware that referenced this pull request Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants