Skip to content

Remove LAYOUTS_HAS_RGB #22917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Remove LAYOUTS_HAS_RGB #22917

merged 1 commit into from
Jan 18, 2024

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jan 18, 2024

Description

Somewhat a bodge for userspace keymaps and CI. Now we have no userspace keymaps, and the userspace workflow has a mechanism to build specific keymaps, this flag is no longer required.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr changed the title Remove LAYOUTS_HAS_RGB Remove LAYOUTS_HAS_RGB Jan 18, 2024
@zvecr zvecr requested a review from a team January 18, 2024 21:37
@zvecr zvecr merged commit d7727a5 into qmk:develop Jan 18, 2024
@zvecr zvecr deleted the rm_layouts_has_rgb branch January 18, 2024 23:07
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants