Skip to content

Remove ee_hands config from ferris/sweep firmware #23029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

keyboard-magpie
Copy link
Contributor

Description

For some reason ferris/sweep was configured with EE_hands as its default handedness method. This provides no real benefit, and confuses new users (sweep is one of our most searched for boards according to analytics).

I've deleted the config.h with the ee_hands define meaning it should fall back to MASTER_LEFT by default, and deleted all the extra stuff in readme.md that related to it.

Just aiming to simplify new users experience with this very popular board.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@drashna drashna merged commit ffc45ac into qmk:develop Feb 7, 2024
tjanas94 added a commit to tjanas94/qmk_firmware that referenced this pull request Mar 5, 2024
@Laobiz
Copy link

Laobiz commented May 22, 2024

I currently have a problem where I am trying to set this up. Both boards are now seen as MASTER_LEFT and are not communicating with each other. Can this be related to that change?
I am flashing with the following commands:

qmk flash -e CONVERT_TO=liatris -kb ferris/sweep -km default -bl uf2-split-left
qmk flash -e CONVERT_TO=liatris -kb ferris/sweep -km default -bl uf2-split-right

nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants